Skip to content

Introducing http-endpoint#96

Closed
verult wants to merge 1 commit into
kubernetes-csi:masterfrom
verult:http-endpoint-major
Closed

Introducing http-endpoint#96
verult wants to merge 1 commit into
kubernetes-csi:masterfrom
verult:http-endpoint-major

Conversation

@verult

@verult verult commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Replacement of #95. Replaces metrics-address and health-port flags with http-endpoint.

Special notes for your reviewer: Requires a major version bump.

Does this PR introduce a user-facing change?:

`--metrics-address` and `--health-port` flags are combined into a single flag, `http-endpoint.` The metrics server is also now always enabled.

/assign @Jiawei0227 @msau42

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 12, 2020
@k8s-ci-robot

k8s-ci-robot commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: verult
To complete the pull request process, please assign msau42 after the PR has been reviewed.
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2020
@verult verult mentioned this pull request Dec 12, 2020
Closed
@Jiawei0227

Jiawei0227 commented Dec 12, 2020

Copy link
Copy Markdown
Contributor

Can you fix the tests? Otherwise this looks good to me! Thanks

@verult verult force-pushed the http-endpoint-major branch from 0d057ef to 8bc04a5 Compare December 14, 2020 21:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2020
@k8s-ci-robot

k8s-ci-robot commented Dec 14, 2020

Copy link
Copy Markdown
Contributor

@verult: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-livenessprobe-1-19-on-kubernetes-1-19 8bc04a5 link /test pull-kubernetes-csi-livenessprobe-1-19-on-kubernetes-1-19
pull-kubernetes-csi-livenessprobe-1-17-on-kubernetes-1-17 8bc04a5 link /test pull-kubernetes-csi-livenessprobe-1-17-on-kubernetes-1-17
pull-kubernetes-csi-livenessprobe-1-18-on-kubernetes-1-18 8bc04a5 link /test pull-kubernetes-csi-livenessprobe-1-18-on-kubernetes-1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@verult

verult commented Dec 14, 2020

Copy link
Copy Markdown
Contributor Author

I'm trying to figure out where the liveness probe spec comes from in these presubmits. If it's from here, wondering if there's a way to overwrite flags in the presubmit job.

@verult

verult commented Dec 15, 2020

Copy link
Copy Markdown
Contributor Author

Unfortunately there's no easy way to overwrite the flag. The options are to (1) keep the old flags and (2) force merge and cut a release right after. (1) is less disruptive. Drafted a new PR with another configuration of old+new flag behavior: #99

@verult verult closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

Assignees

@Jiawei0227 Jiawei0227

@msau42 msau42

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@verult @k8s-ci-robot @Jiawei0227 @msau42