Skip to content

1.3: fix Fix claimRef and snapshotRef checks#354

Merged
k8s-ci-robot merged 1 commit into
kubernetes-csi:release-1.3from
jsafrane:1.3-claimref-checks
Oct 8, 2019
Merged

1.3: fix Fix claimRef and snapshotRef checks#354
k8s-ci-robot merged 1 commit into
kubernetes-csi:release-1.3from
jsafrane:1.3-claimref-checks

Conversation

@jsafrane

@jsafrane jsafrane commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixed checking of binding of PVC and Snapshots when creating volumes.

Does this PR introduce a user-facing change?:

Added extra verification of source Snapshot and PersistentVolumeClaim before provisioning.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2019
@k8s-ci-robot k8s-ci-robot requested a review from msau42 October 8, 2019 08:27
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from saad-ali October 8, 2019 08:27
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 8, 2019
@msau42

msau42 commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8eeb15b into kubernetes-csi:release-1.3 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants