Need to check VolumeContentSource if creating volume from snapshot by zhucan · Pull Request #283 · kubernetes-csi/external-provisioner

zhucan · 2019-05-23T08:37:15Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
Need to check VolumeContentSource if creating volume from snapshot
Which issue(s) this PR fixes:

Fixes #280

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checks if volume content source is populated if creating a volume from a snapshot source.

k8s-ci-robot · 2019-05-23T08:37:16Z

Welcome @zhucan!

It looks like this is your first PR to kubernetes-csi/external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-05-23T08:37:17Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-05-23T08:37:31Z

Hi @zhucan. Thanks for your PR.

I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xing-yang

Please add a unit test.

xing-yang · 2019-05-29T02:32:50Z

Please add a release note:

Checks if volume content source is populated if creating a volume from a snapshot source.

j-griffith

Other than the 2 items noted by Xing this looks good to me.

k8s-ci-robot · 2019-06-03T02:34:25Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

xing-yang · 2019-06-10T15:34:28Z

/retest

msau42 · 2019-06-12T17:14:58Z

/ok-to-test

zhucan · 2019-06-18T07:48:03Z

@zhucan Please check the unit test failure in pull-kubernetes-csi-external-provisioner-unit. Thanks.

ok

msau42 · 2019-07-23T00:09:48Z

/approve

Can you squash your commits?

k8s-ci-robot · 2019-07-23T00:09:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, zhucan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zhucan · 2019-07-23T03:31:13Z

@msau42 I have squashed it

msau42

Thanks, this lgtm, just have one minor nit. Can you also squash your commits?

bugfix-280 fix comments add retry count exec 'make -k all test' failed update print for logs modify comment No need to check the rc again

msau42 · 2019-09-10T16:02:53Z

/lgtm
Thanks!

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 23, 2019

k8s-ci-robot requested review from msau42 and saad-ali May 23, 2019 08:37

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 23, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 23, 2019

zhucan force-pushed the bugfix-280 branch from 27f5379 to d95d0a7 Compare May 23, 2019 08:40

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 23, 2019

xing-yang reviewed May 29, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

Comment thread pkg/controller/controller.go Outdated

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 29, 2019

j-griffith reviewed May 29, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

humblec reviewed May 29, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

zhucan force-pushed the bugfix-280 branch from 1351dec to 8c869ab Compare June 3, 2019 02:37

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 3, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2019

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 18, 2019

zhucan force-pushed the bugfix-280 branch 2 times, most recently from 2a1d74b to a297985 Compare June 18, 2019 07:46

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 18, 2019

msau42 reviewed Jun 20, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

Comment thread pkg/controller/controller.go

Comment thread pkg/controller/controller_test.go Outdated

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 20, 2019

msau42 reviewed Jul 17, 2019

View reviewed changes

Comment thread pkg/controller/controller_test.go

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019

zhucan force-pushed the bugfix-280 branch from 44dbed4 to a10dd00 Compare July 23, 2019 02:54

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2019

zhucan force-pushed the bugfix-280 branch from a10dd00 to 16330ca Compare July 23, 2019 03:29

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 23, 2019

jingxu97 reviewed Jul 23, 2019

View reviewed changes

Comment thread pkg/controller/controller.go

msau42 reviewed Sep 6, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

Comment thread pkg/controller/controller.go Outdated

msau42 reviewed Sep 6, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

msau42 reviewed Sep 10, 2019

View reviewed changes

Comment thread pkg/controller/controller.go Outdated

Need to check VolumeContentSource if creating volume from snapshot

a319671

bugfix-280 fix comments add retry count exec 'make -k all test' failed update print for logs modify comment No need to check the rc again

xing-yang mentioned this pull request Dec 11, 2019

Clarify that VolumeContentSource is required for pre-populated volumes container-storage-interface/spec#404

Open

hseipp mentioned this pull request Jan 7, 2020

Rook/Ceph CSI 1.1.8 and later: Restore snapshot to PVC is pending forever rook/rook#4624

Closed

joejulian mentioned this pull request Mar 6, 2020

chore: update awsebscsiprovisioner chart mesosphere/charts#492

Merged

Conversation

zhucan commented May 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented May 23, 2019

Uh oh!

k8s-ci-robot commented May 23, 2019

Uh oh!

k8s-ci-robot commented May 23, 2019

Uh oh!

xing-yang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xing-yang commented May 29, 2019

Uh oh!

j-griffith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Jun 3, 2019

Uh oh!

xing-yang commented Jun 10, 2019

Uh oh!

msau42 commented Jun 12, 2019

Uh oh!

zhucan commented Jun 18, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msau42 commented Jul 23, 2019

Uh oh!

k8s-ci-robot commented Jul 23, 2019

Uh oh!

zhucan commented Jul 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msau42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

msau42 commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zhucan commented May 23, 2019 •

edited

Loading