Skip to content

WIP: prow.sh: install dep if needed#178

Closed
pohly wants to merge 1 commit into
kubernetes-csi:masterfrom
pohly:dep-vendor-test
Closed

WIP: prow.sh: install dep if needed#178
pohly wants to merge 1 commit into
kubernetes-csi:masterfrom
pohly:dep-vendor-test

Conversation

@pohly

@pohly pohly commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

dep must be installed explicitly for the "make test-vendor" check.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2019
@k8s-ci-robot

k8s-ci-robot commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2019
@pohly
prow.sh: install dep if needed
637666a 
"make test-vendor" depends on dep if the current project uses
dep. Without it, the vendor directory checking was skipped under Prow.
@k8s-ci-robot

k8s-ci-robot commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

@pohly: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-attacher-unit 637666a link /test pull-kubernetes-csi-external-attacher-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pohly pohly mentioned this pull request Aug 29, 2019
Merged
@pohly

pohly commented Sep 12, 2019

Copy link
Copy Markdown
Contributor Author

kubernetes-csi/csi-release-tools#27 was merged. The next regular csi-release-tools update can pick this up.

@pohly pohly closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pohly @k8s-ci-robot