wait for snapshot ReadyToUse before using#525
Conversation
|
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| By("creating a volume") | ||
| vol1Req := MakeCreateVolumeReq(sc, UniqueString("sanity-controller-source-vol")) | ||
| snap, _ := r.MustCreateSnapshotFromVolumeRequest(context.Background(), vol1Req, UniqueString("sanity-controller-snap-from-vol")) | ||
| vol1 := r.MustCreateVolume(context.Background(), vol1Req) |
There was a problem hiding this comment.
MustCreateSnapshotFromVolumeRequest is called in multiple places. Can you modify that instead of replacing it at this one place?
There was a problem hiding this comment.
Only this snapshot is actually used for creating volume. So I think only this one needs fix. All other places are fine.
There was a problem hiding this comment.
@xing-yang Could you PTAL again? thanks.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huww98, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
wait for snapshot ReadyToUse before using
Which issue(s) this PR fixes:
Fixes test failure due to not ready snapshots
Special notes for your reviewer:
Does this PR introduce a user-facing change?: