Skip to content

Automated cherry pick of #127: add option to limit grpc logging length#128

Closed
leiyiz wants to merge 1 commit into
kubernetes-csi:release-0.12from
leiyiz:automated-cherry-pick-of-#127-release-0.12
Closed

Automated cherry pick of #127: add option to limit grpc logging length#128
leiyiz wants to merge 1 commit into
kubernetes-csi:release-0.12from
leiyiz:automated-cherry-pick-of-#127-release-0.12

Conversation

@leiyiz

@leiyiz leiyiz commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

Cherry pick of #127 on release-0.12.

#127: add option to limit grpc logging length

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2023
@k8s-ci-robot

k8s-ci-robot commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leiyiz
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval by writing /assign @jsafrane in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2023
@leiyiz

leiyiz commented Jan 18, 2023

Copy link
Copy Markdown
Contributor Author

/assign @jsafrane

@jsafrane

jsafrane commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

Does it make sense to backport this change? It does not look like a bugfix to me.

@leiyiz

leiyiz commented Jan 18, 2023

Copy link
Copy Markdown
Contributor Author

I guess what I'm trying to do is to release a new version of csi-lib-utils to include this and it seemed fit to do a 0.12.1 version because it is not introducing any breaking changes.

@msau42

msau42 commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

I think it's ok to release a 0.13.0 and use that in csi-attacher

@leiyiz leiyiz closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@j-griffith j-griffith Awaiting requested review from j-griffith

Assignees

@jsafrane jsafrane

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leiyiz @k8s-ci-robot @jsafrane @msau42