Skip to content

add WithCustomRegistry for metrics#118

Merged
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
ayanamist:master
Dec 22, 2022
Merged

add WithCustomRegistry for metrics#118
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
ayanamist:master

Conversation

@ayanamist

@ayanamist ayanamist commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
If users want to monitor workqueue metrics, they usually import k8s.io/component-base/metrics/prometheus/workqueue, which registers to k8s.io/component-base/metrics/legacyregistry, however, csiMetricsManager is using its own newly-created registry.

Which issue(s) this PR fixes:
Make a new method WithCustomRegistry to let users pass in an exist registry.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds WithCustomRegistry method to the metrics pkg to allow reuse of an existing registry.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2022
@k8s-ci-robot

k8s-ci-robot commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Welcome @ayanamist!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2022
@k8s-ci-robot

k8s-ci-robot commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Hi @ayanamist. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2022
@ggriffiths

ggriffiths commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2022
@ggriffiths

ggriffiths commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

I don't see any issues with this change. Can you clarify the release note though? Something like this-

Adds WithCustomRegistry method to the metrics pkg to allow reuse of an existing registry.

ggriffiths
ggriffiths approved these changes Sep 15, 2022
View reviewed changes

@ggriffiths ggriffiths left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@ayanamist

ayanamist commented Sep 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I don't see any issues with this change. Can you clarify the release note though? Something like this-

Adds WithCustomRegistry method to the metrics pkg to allow reuse of an existing registry.

Do you mean edit the content of PR or commit message? I have modified both.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@k8s-triage-robot

k8s-triage-robot commented Dec 14, 2022

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2022
@ayanamist

ayanamist commented Dec 14, 2022

Copy link
Copy Markdown
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2022
@sunnylovestiramisu

sunnylovestiramisu commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Is this compatible with k8s.io/component-base v0.26.0?

@ayanamist

ayanamist commented Dec 21, 2022

Copy link
Copy Markdown
Contributor Author

Is this compatible with k8s.io/component-base v0.26.0?

Yes, it is compatible.

@msau42

msau42 commented Dec 22, 2022

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@k8s-ci-robot

k8s-ci-robot commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayanamist, ggriffiths, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit dadad61 into kubernetes-csi:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

1 more reviewer

@ggriffiths ggriffiths ggriffiths approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ggriffiths ggriffiths

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ayanamist @k8s-ci-robot @ggriffiths @k8s-triage-robot @sunnylovestiramisu @msau42