Skip to content

update to Go 1.12.4#39

Closed
pohly wants to merge 2 commits into
kubernetes-csi:masterfrom
pohly:prow
Closed

update to Go 1.12.4#39
pohly wants to merge 2 commits into
kubernetes-csi:masterfrom
pohly:prow

Conversation

@pohly

@pohly pohly commented Apr 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

pohly added 2 commits April 15, 2019 09:45
@pohly
update to Go 1.12.4
e157b6b 
Kubernetes also requires 1.12. We pick the latest stable release
for CI builds.
@pohly
Merge commit 'e157b6b514ace191f46d4c879491cb7d11684659' into prow
9e785f5
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2019
@k8s-ci-robot

k8s-ci-robot commented Apr 15, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 15, 2019 08:51
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2019
@pohly pohly marked this pull request as ready for review April 15, 2019 09:05
@pohly

pohly commented Apr 15, 2019

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-csi-csi-driver-host-path-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-csi-driver-host-path-1-13-on-kubernetes-master
/test pull-kubernetes-csi-csi-driver-host-path-1-14-on-kubernetes-1-14
/test pull-kubernetes-csi-csi-driver-host-path-1-14-on-kubernetes-master
/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-13-on-kubernetes-1-13
/test pull-kubernetes-csi-csi-driver-host-path-alpha-1-14-on-kubernetes-1-14
/test pull-kubernetes-csi-csi-driver-host-path-unit

@pohly pohly changed the title WIP: update to Go 1.12.4 update to Go 1.12.4 Apr 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@msau42

msau42 commented Apr 15, 2019

Copy link
Copy Markdown
Collaborator

/lgtm
/hold
until we after we release a new hostpath driver

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 15, 2019
@pohly pohly mentioned this pull request Jul 9, 2019
Merged
@fejta-bot

fejta-bot commented Jul 14, 2019

Copy link
Copy Markdown

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2019
@pohly

pohly commented Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

Was merged via #76

@pohly pohly closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pohly @k8s-ci-robot @msau42 @fejta-bot