Skip to content

WIP: Test snapshotter v2.0.0 and other changes#135

Closed
ggriffiths wants to merge 1 commit into
kubernetes-csi:masterfrom
ggriffiths:test_snapshotter_2.0.0
Closed

WIP: Test snapshotter v2.0.0 and other changes#135
ggriffiths wants to merge 1 commit into
kubernetes-csi:masterfrom
ggriffiths:test_snapshotter_2.0.0

Conversation

@ggriffiths

@ggriffiths ggriffiths commented Jan 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Grant Griffiths grant@portworx.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@ggriffiths
Test snapshotter v2.0.0
fcf97e0 
Signed-off-by: Grant Griffiths <grant@portworx.com>
@k8s-ci-robot

k8s-ci-robot commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

@ggriffiths: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2020
@k8s-ci-robot

k8s-ci-robot commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ggriffiths
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2020
@ggriffiths ggriffiths changed the title Test snapshotter v2.0.0 and other changes WIP: Test snapshotter v2.0.0 and other changes Jan 8, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2020
@ggriffiths ggriffiths mentioned this pull request Jan 8, 2020
Merged
@k8s-ci-robot

k8s-ci-robot commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

@ggriffiths: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-unit fcf97e0 link /test pull-kubernetes-csi-csi-driver-host-path-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggriffiths ggriffiths closed this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggriffiths @k8s-ci-robot