This repository was archived by the owner on Mar 13, 2022. It is now read-only.
add proxy authentication supporting for websocket (stream/ws_client.py)#256
Merged
k8s-ci-robot merged 3 commits intokubernetes-client:masterfrom Oct 9, 2021
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR supports proxy authentication for websocket client.
as described in #255, and ansible-collections/kubernetes.core#246
current kubernets-client/python(-base) support proxy auth only for REST but NOT websocket.
as the result, kubernets.core's k8s_cp nor k8s_exec cannot work with proxy when proxy requires authentication.
Which issue(s) this PR fixes:
Fixes #255
Fixes ansible-collections/kubernetes.core#246
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: