add 'list_ingressroute_for_all_namespaces' method#1454
Conversation
|
|
||
|
|
||
| def delete_namespace(namespace_api, name): | ||
| namespace_deleted = namespace_api.delete(name=name) |
There was a problem hiding this comment.
namespace_deleted is not used, do you need to assign to it?
There was a problem hiding this comment.
Thank you for pointing. No, the variable namespace_deleted is not required.
I've removed it.
There was a problem hiding this comment.
Thank you for pointing. No, the variable namespace is not required. I've removed it.
|
please squash the commits, otherwise looks good. |
e1480d8 to
eb952e7
Compare
|
Thank you. I've squashed the commits. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
As mentioned in the linked issue, there is a suggestion to implement a
list_ingressroute_for_all_namespacesmethod, which is meant for listing all theingressroutesresources across all the namespaces. This PR adds changes to implement the same.This new method,
list_ingressroute_for_all_namespacesis analogous to executingkubectl get ingressroutes --all-namespacescommand.Besides, implementing the above method, the PR also include changes for demonstrating creation & deletion of k8s namespace resources using
dynamic client. The methods implemented arecreate_namespace&deleted_namespace.Output of the script:
Which issue(s) this PR fixes:
Fixes #1388
Does this PR introduce a user-facing change?