add example to demonstrate a rolling restart of the deployment#1450
Conversation
1cde490 to
00a87f9
Compare
| ) | ||
|
|
||
| # fetching the deployment api | ||
| api = client.resources.get(api_version="apps/v1", kind="Deployment") |
There was a problem hiding this comment.
any reason for using dynamic client, instead of using the typed client?
There was a problem hiding this comment.
HI @yliaog, thanks for the reveiw.
No, there is no specific reason for using dynamic client. I've just replicated the same example using the typed client. If required, I can replace this example with the one using typed client.
Thank you!
There was a problem hiding this comment.
ok. i think typed client would benefit from such an example too.
There was a problem hiding this comment.
Thanks @yliaog. I'll add the same example using the typed client too.
00a87f9 to
83f92cc
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR add
examples/dynamic-client/deployment_rollout-restart.pypython script, to demonstrate how to perform a rolling restart on a deployment resource.The output of the script looks like:
Which issue(s) this PR fixes:
Fixes #1378
Does this PR introduce a user-facing change?