Skip to content

Leader Election issue #434#1218

Closed
Invictus17 wants to merge 1 commit intokubernetes-client:masterfrom
Invictus17:master
Closed

Leader Election issue #434#1218
Invictus17 wants to merge 1 commit intokubernetes-client:masterfrom
Invictus17:master

Conversation

@Invictus17
Copy link
Copy Markdown
Contributor

PR for the Leader Election functionality for the Kubernetes python client

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 30, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Invictus17
To complete the pull request process, please assign roycaihw
You can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from roycaihw and yliaog July 30, 2020 07:41
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @Invictus17!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 30, 2020
@Invictus17
Copy link
Copy Markdown
Contributor Author

Invictus17 commented Jul 30, 2020

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

I have signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 30, 2020
@Invictus17
Copy link
Copy Markdown
Contributor Author

/assign @roycaihw

@Invictus17
Copy link
Copy Markdown
Contributor Author

Hi @roycaihw @yliaog, can you please review my PR?

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Jul 31, 2020

sure, it seems all files are under examples directory? the main logic should not be in examples.

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Jul 31, 2020

also, it should be in https://github.com/kubernetes-client/python-base repo

@Invictus17
Copy link
Copy Markdown
Contributor Author

also, it should be in https://github.com/kubernetes-client/python-base repo

Apologies, I'll create a new PR on the python-base repo. Any suggestion on how I could rearrange the files?

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Jul 31, 2020

at the top level is fine, alongside 'watch' 'stream'

@Invictus17
Copy link
Copy Markdown
Contributor Author

at the top level is fine, alongside 'watch' 'stream'

Thanks, should I be closing this PR?

@yliaog
Copy link
Copy Markdown
Contributor

yliaog commented Jul 31, 2020

sure, please close it. you can reopen it if needed anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants