Leader Election issue #434#1218
Leader Election issue #434#1218Invictus17 wants to merge 1 commit intokubernetes-client:masterfrom Invictus17:master
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Invictus17 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @Invictus17! |
I have signed it |
|
/assign @roycaihw |
|
sure, it seems all files are under examples directory? the main logic should not be in examples. |
|
also, it should be in https://github.com/kubernetes-client/python-base repo |
Apologies, I'll create a new PR on the python-base repo. Any suggestion on how I could rearrange the files? |
|
at the top level is fine, alongside 'watch' 'stream' |
Thanks, should I be closing this PR? |
|
sure, please close it. you can reopen it if needed anytime. |
PR for the Leader Election functionality for the Kubernetes python client