Welcome @cyrilcsr!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Looks good. It would be great to add unit tests so that we don't regress in the future.

Looks good. It would be great to add unit tests so that we don't regress in the future.

I have added a few unit tests for building list call. I'm not sure which test file should I put these unit tests, so I created a new GenericKubernetesListApiTest file which refers to the GenericKubernetesGetApiTest file. Please take a look.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyrilcsr, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here