feat: add GET listCustomObjectForAllNamespaces#269
Conversation
|
Welcome @davidxia! |
6b1ba62 to
c9eb266
Compare
for the API path `/apis/{group}/{version}/{plural}`.
We define a new key `/apis/{group}/{version}/{plural}#[U+200E]`
in `custom_objects_spec.json` to work around this limitation.
> OpenAPI defines a unique operation as a combination of a path and an HTTP
> method. This means that two GET or two POST methods for the same path are not
> allowed.
— https://swagger.io/docs/specification/paths-and-operations
We use the hair space empty character to visually hide this path param from the
Swagger UI.
addresses kubernetes-client#268
Work around was taken from [here][1].
[1]: OAI/OpenAPI-Specification#182 (comment)
c9eb266 to
317500f
Compare
|
@davidxia thanks for the PR, this looks good to me, have you tested it with code generation? |
With this export KUBERNETES_BRANCH="master"
export CLIENT_VERSION="31.0.0b1"
export PACKAGE_NAME="client"I ran from root of this repo Here's the full generated Python client and link to list_custom_object_for_all_namespaces(). Lmk if this looks good or other things I should test. |
|
Thanks, looks good to me. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, davidxia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@brendandburns Amazing, thank you. Are there any docs on or do you know the release cadence of clients from changes in this repo? For kubernetes-client/python it looks like an ad-hoc cadence? |
for the API path
/apis/{group}/{version}/{plural}. We define a new key/apis/{group}/{version}/{plural}#[U+200E]incustom_objects_spec.jsonto work around this limitation.— https://swagger.io/docs/specification/paths-and-operations
We use the hair space empty character to visually hide this path param from the Swagger UI.
addresses #268
Work around was taken from here.