Implement KubectlDelete to delete Kubernetes resources by Copilot · Pull Request #1696 · kubernetes-client/csharp

Copilot · 2025-12-10T19:27:20Z

Adds kubectl delete equivalent functionality to the Kubectl package, enabling deletion of Kubernetes resources by name.

Implementation

AsyncKubectl.Delete.cs: DeleteAsync<T> method supporting both namespaced and cluster-scoped resources via GenericClient
Kubectl.Delete.cs: Synchronous Delete<T> wrapper following existing patterns
KubectlTests.Delete.cs: Test coverage for Pod, Service, Deployment (namespaced) and Namespace (cluster-scoped)

Usage

var kubectl = new Kubectl(client);

// Namespaced resource
var deletedPod = kubectl.Delete<V1Pod>("my-pod", "default");

// Cluster-scoped resource
var deletedNs = kubectl.Delete<V1Namespace>("my-namespace");

// Async with cancellation
var deleted = await asyncKubectl.DeleteAsync<V1Service>("my-service", "default", cancellationToken);

The implementation automatically determines resource scope from type metadata and delegates to GenericClient's existing delete operations.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

crl.comodoca.com
- Triggering command: /home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet /home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/csharp/csharp/src/KubernetesClient.Classic/KubernetesClient.Classic.csproj --packages /home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot bash --no�� ct tificateValidationTests.cs grep (dns block)
kubernetes.io
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
ocsp.comodoca.com
- Triggering command: /home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet /home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/csharp/csharp/src/KubernetesClient.Classic/KubernetesClient.Classic.csproj --packages /home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/home/REDACTED/work/csharp/.codeql-scratch/dbs/csharp/working/emptyFakeDotnetRoot bash --no�� ct tificateValidationTests.cs grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Implement KubectlDelete to delete resources</issue_title>
<issue_description>The Kubectl package does not currently support the equivalent of kubectl delete ...

</issue_description>

<agent_instructions>The full details of kubectl delete can be found here: https://kubernetes.io/docs/reference/kubectl/generated/kubectl_delete/ please implement them in csharp.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes Implement KubectlDelete to delete resources #1695

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

brendandburns

/lgtm
/approve

Copilot

Pull request overview

This PR adds support for deleting Kubernetes resources through the Kubectl package, implementing the equivalent of kubectl delete command. The implementation follows the established patterns in the codebase, using the existing GenericClient infrastructure and providing both async and synchronous APIs.

Key Changes:

Added DeleteAsync<T> method in AsyncKubectl for asynchronous delete operations with proper ConfigureAwait(false) pattern
Added synchronous Delete<T> wrapper method in Kubectl following existing patterns
Added comprehensive unit tests covering both namespaced (Pod, Service, Deployment) and cluster-scoped (Namespace) resources

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/KubernetesClient.Kubectl/Beta/AsyncKubectl.Delete.cs	Implements async DeleteAsync method using GenericClient, supporting both namespaced and cluster-scoped resources
src/KubernetesClient.Kubectl/Beta/Kubectl.Delete.cs	Provides synchronous Delete wrapper using GetAwaiter().GetResult() pattern
tests/Kubectl.Tests/KubectlTests.Delete.cs	Adds four test cases covering Pod, Service, Deployment, and Namespace deletion with verification

The implementation is well-structured and consistent with existing code. However, the tests could be improved by adding try-finally blocks for proper resource cleanup in case of test failures, which is the established pattern in other tests in this codebase (e.g., KubectlTests.Get.cs).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/Kubectl.Tests/KubectlTests.Delete.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

brendandburns · 2025-12-10T19:59:28Z

/lgtm
/approve

k8s-ci-robot · 2025-12-10T19:59:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Initial plan

860cee0

Copilot AI assigned Copilot and brendandburns Dec 10, 2025

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2025

Copilot started work on behalf of brendandburns December 10, 2025 19:27 View session

Implement KubectlDelete functionality

04df607

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2025

Address code review feedback: Remove Thread.Sleep from test

b4d8083

Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>

brendandburns marked this pull request as ready for review December 10, 2025 19:46

Copilot AI review requested due to automatic review settings December 10, 2025 19:46

k8s-ci-robot requested review from brendandburns and tg123 December 10, 2025 19:46

Copilot started reviewing on behalf of brendandburns December 10, 2025 19:46 View session

brendandburns approved these changes Dec 10, 2025

View reviewed changes

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2025

Copilot AI changed the title ~~[WIP] Add support for KubectlDelete to remove resources~~ Implement KubectlDelete to delete Kubernetes resources Dec 10, 2025

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2025

Copilot finished work on behalf of brendandburns December 10, 2025 19:49

Copilot AI requested a review from brendandburns December 10, 2025 19:49

Copilot AI reviewed Dec 10, 2025

View reviewed changes

Update tests/Kubectl.Tests/KubectlTests.Delete.cs

1ed1b37

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2025

brendandburns and others added 3 commits December 10, 2025 11:58

Update tests/Kubectl.Tests/KubectlTests.Delete.cs

dd4b8a0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/Kubectl.Tests/KubectlTests.Delete.cs

f5a9eac

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update tests/Kubectl.Tests/KubectlTests.Delete.cs

c1fc3ea

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2025

k8s-ci-robot merged commit 53fe2a7 into master Dec 10, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement KubectlDelete to delete Kubernetes resources#1696

Implement KubectlDelete to delete Kubernetes resources#1696
k8s-ci-robot merged 7 commits intomasterfrom
copilot/implement-kubectl-delete

Copilot AI commented Dec 10, 2025 •

edited

Loading

Uh oh!

brendandburns left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brendandburns commented Dec 10, 2025

Uh oh!

k8s-ci-robot commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Implementation

Usage

I tried to connect to the following addresses, but was blocked by firewall rules:

Comments on the Issue (you are @copilot in this section)

Uh oh!

brendandburns left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes:

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brendandburns commented Dec 10, 2025

Uh oh!

k8s-ci-robot commented Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Dec 10, 2025 •

edited

Loading