fix: yaml ByteArrayStringYamlConverter output new lines#1651
Merged
k8s-ci-robot merged 3 commits intokubernetes-client:masterfrom Aug 27, 2025
Merged
fix: yaml ByteArrayStringYamlConverter output new lines#1651k8s-ci-robot merged 3 commits intokubernetes-client:masterfrom
k8s-ci-robot merged 3 commits intokubernetes-client:masterfrom
Conversation
Contributor
|
Can you add a unit test so that we maintain this behavior going forward? |
Member
|
LTGM could you please also fix the style warning introduced by new code |
Member
|
i am going to publish new nuget by eod (pdt) any chance to take this fix? |
Contributor
Author
|
@tg123, give me a few mins just adding some tests. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IvanJosipovic, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
69afa49
into
kubernetes-client:master
13 of 14 checks passed
This was referenced Aug 28, 2025
This was referenced Sep 17, 2025
This was referenced Sep 17, 2025
This was referenced Oct 13, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
This PR resolves the formatting problem where KubernetesYaml.Serialize() was introducing extra newlines in the output. Secrets and other multi-line values now serialize without unintended blank lines.
Before:
After: