Clean up warnings in examples#1628
Merged
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom Apr 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up warnings in the sample projects by removing unnecessary namespace and class wrappers and leveraging top‑level statements and new language features.
- Removed redundant using directives and async Main methods.
- Updated comments and documentation parameters.
- Adopted modern C# patterns for top‑level statements across multiple examples.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/yaml/Program.cs | Removed threading-related using and wrapper class/namespace for top‑level code. |
| examples/webApiDependencyInjection/Controllers/ExampleDependencyInjectionOnMethodController.cs | Improved XML comments and added null-check with ArgumentNullException.ThrowIfNull. |
| examples/webApiDependencyInjection/Controllers/ExampleDependencyInjectionOnConstructorController.cs | Updated documentation and refined the method signature for clarity. |
| examples/watch/Program.cs | Converted callback method into a top‑level function with updated warning suppression. |
| examples/simple/PodList.cs | Refactored from namespace encapsulation to top‑level code. |
| examples/portforward/PortForward.cs | Converted the Forward method to a top‑level async function. |
| examples/patch/Program.cs | Removed namespace/class wrappers, updated PrintLabels to a top‑level function. |
| examples/namespace/NamespaceExample.cs | Eliminated namespace declaration to allow top‑level function definitions. |
| examples/metrics/Program.cs | Converted multiple async methods to top‑level functions. |
| examples/logs/Logs.cs | Removed namespace and async Task structure in favor of top‑level statements. |
| examples/labels/PodList.cs | Simplified structure by removing redundant namespace/class wrappers. |
| examples/generic/Generic.cs | Refactored out of namespace for top-level code style. |
| examples/exec/Exec.cs | Converted methods to top-level functions while retaining async invocation. |
| examples/csrApproval/Program.cs | Updated the X509EnhancedKeyUsageExtension initializer to utilize new syntax. |
| examples/attach/Attach.cs | Changed AttachToPod to a top-level async function format. |
Files not reviewed (1)
- Directory.Build.props: Language not supported
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ae79be6
into
kubernetes-client:master
13 of 14 checks passed
This was referenced Aug 31, 2025
This was referenced Sep 17, 2025
This was referenced Sep 17, 2025
This was referenced Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.