Skip to content

Remove the need to check cgroups#9410

Closed
erickhun wants to merge 1 commit intokubernetes:masterfrom
erickhun:patch-2
Closed

Remove the need to check cgroups#9410
erickhun wants to merge 1 commit intokubernetes:masterfrom
erickhun:patch-2

Conversation

@erickhun
Copy link
Copy Markdown
Contributor

@erickhun erickhun commented Jul 7, 2018

kubeadm 1.1 automatically get that information

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bradtopol

Assign the PR to them by writing /assign @bradtopol in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Jul 7, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a4a6001

https://deploy-preview-9410--kubernetes-io-master-staging.netlify.com

kubeadm 1.1 automatically get that information
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 7, 2018
@neolit123
Copy link
Copy Markdown
Member

neolit123 commented Jul 7, 2018

@erickhun thank you for you contribution.

kubeadm only sets the cgroup driver automatically in the case of Docker. all other CRI remain using cgroupfs which is the default value of the kubelet.

instead of removing this section modify it to:

## Configure cgroup driver used by kubelet on Master Node

When using Docker, kubeadm will detect the cgroup driver for the kubelet
automatically and set in the file `/var/lib/kubelet/kubeadm-flags.env`
on runtime.

If you are using a different CRI, you have to modify the the drop-in file
`/etc/systemd/system/kubelet.service.d/10-kubeadm.conf`, by adding
`--cgroup-driver=<driver-name>`.

Please mind, that you **only** have to do that if the cgroup driver of your CRI
is not `cgroupfs`, because that is the default value in the kubelet already.

/cc @kubernetes/sig-cluster-lifecycle-pr-reviews @Bradamant3
^ comments / edits on the above?
/hold

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 7, 2018
@neolit123
Copy link
Copy Markdown
Member

/assign

@neolit123
Copy link
Copy Markdown
Member

sent new PR for this:
#9541

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants