Skip to content

Remove old Dockerfile for Jekyll site#9215

Closed
tfogo wants to merge 1 commit intokubernetes:masterfrom
tfogo:tf-remove-old-dockerfile
Closed

Remove old Dockerfile for Jekyll site#9215
tfogo wants to merge 1 commit intokubernetes:masterfrom
tfogo:tf-remove-old-dockerfile

Conversation

@tfogo
Copy link
Copy Markdown
Contributor

@tfogo tfogo commented Jun 25, 2018

PR #9128 added a new Dockerfile for the Hugo site. The old
staging container is no longer needed.

@tfogo
Remove old Dockerfile for Jekyll site
64e9595 
PR kubernetes#9128 added a new Dockerfile for the Hugo site. The old
staging container is no longer needed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 25, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mistyhacks

Assign the PR to them by writing /assign @mistyhacks in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tfogo
Copy link
Copy Markdown
Contributor Author

tfogo commented Jun 25, 2018

/assign @MistyHacks

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Jun 25, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 64e9595

https://deploy-preview-9215--kubernetes-io-master-staging.netlify.com

@mdlinville
Copy link
Copy Markdown
Contributor

mdlinville commented Jun 26, 2018

@lucperkins Should you cherry-pick your commit from your other PR into this one, to keep all of this type of work into one PR?

@lucperkins
Copy link
Copy Markdown
Contributor

lucperkins commented Jun 27, 2018

@tfogo I agree with @MistyHacks that it'd be best to consolidate the Docker-related changes into a single PR.

@tfogo
Copy link
Copy Markdown
Contributor Author

tfogo commented Jun 27, 2018

@lucperkins sure thing. @MistyHacks is there a PR from @lucperkins that should be cherry picked into this one or did you mean from my other PR touching the Dockerfile (#9216)?

@chenopis
Copy link
Copy Markdown
Contributor

chenopis commented Jul 19, 2018

/hold
Consolidate the PRs and close the one that's no longer needed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2018
@chenopis chenopis mentioned this pull request Jul 19, 2018
Merged
@tfogo
Copy link
Copy Markdown
Contributor Author

tfogo commented Jul 20, 2018

This has been consolidated into #9216. Closing this PR.

@tfogo tfogo closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@mdlinville mdlinville

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tfogo @k8s-ci-robot @k8sio-netlify-preview-bot @mdlinville @lucperkins @chenopis