Skip to content

Blog post: Project Gardener#8546

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rfranzke:gardener
May 17, 2018
Merged

Blog post: Project Gardener#8546
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rfranzke:gardener

Conversation

@rfranzke
Copy link
Copy Markdown
Contributor

@rfranzke rfranzke commented May 15, 2018

Adding a blog post on project Gardener.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2018
@rfranzke
Copy link
Copy Markdown
Contributor Author

rfranzke commented May 15, 2018

/assign @bobsky @kbarnard10

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented May 15, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2a4988b

https://deploy-preview-8546--kubernetes-io-master-staging.netlify.com

@rfranzke rfranzke force-pushed the gardener branch 6 times, most recently from 2ca66ee to 087e48f Compare May 15, 2018 17:11
@kbarnard10
Copy link
Copy Markdown
Contributor

kbarnard10 commented May 15, 2018

/hold
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 15, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2018
@ajaeger
Copy link
Copy Markdown
Contributor

ajaeger commented May 15, 2018

Question: Why is netlify content not showing the new blog post? Check https://deploy-preview-8546--kubernetes-io-master-staging.netlify.com/blog/

is something missing here, @kbarnard10 ?

Otherwise, this looks fine!

@rfranzke
Copy link
Copy Markdown
Contributor Author

rfranzke commented May 15, 2018

@ajaeger It's probably because the date is in the future (thursday). When I was trying to run the website locally I couldn't see the blog entry as well. Only after I changed the date to something <= now it was showing up on the blogs page.

@ajaeger
Copy link
Copy Markdown
Contributor

ajaeger commented May 15, 2018

@rfranzke, thanks.

@vasu1124
Copy link
Copy Markdown
Contributor

vasu1124 commented May 17, 2018

/test

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2018
@rfranzke
Copy link
Copy Markdown
Contributor Author

rfranzke commented May 17, 2018

FYI: Pushed once more to retrigger the netlify preview. Now the post is visible.

@kbarnard10
Copy link
Copy Markdown
Contributor

kbarnard10 commented May 17, 2018

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8f1fe16 into kubernetes:master May 17, 2018
@rfranzke rfranzke deleted the gardener branch May 17, 2018 20:11
@rfranzke rfranzke mentioned this pull request Nov 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bobsky bobsky

@kbarnard10 kbarnard10

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rfranzke @k8sio-netlify-preview-bot @kbarnard10 @k8s-ci-robot @ajaeger @vasu1124 @bobsky