Skip to content

Remove job's scale-related operations#7681

Closed
soltysh wants to merge 1 commit intokubernetes:masterfrom
soltysh:issue7395
Closed

Remove job's scale-related operations#7681
soltysh wants to merge 1 commit intokubernetes:masterfrom
soltysh:issue7395

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Mar 8, 2018

Fixes #7395 by removing all job's scale-relate information. Scale subresource does not exists for Jobs, and kubectl scale is deprecated so it's not worth advertising it to users anymore.

/milestone 1.10

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 8, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bradamant3

Assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor Author

soltysh commented Mar 8, 2018

@DirectXMan12 fyi

@soltysh
Copy link
Contributor Author

soltysh commented Mar 8, 2018

/milestone v1.10

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 8, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c3548a6

https://deploy-preview-7681--kubernetes-io-master-staging.netlify.com

@bradtopol bradtopol self-assigned this Mar 8, 2018
@Bradamant3 Bradamant3 added this to the 1.10 milestone Mar 8, 2018
@Bradamant3
Copy link
Contributor

Bradamant3 commented Mar 8, 2018

@soltysh could you please resubmit/rebase against the 1.10 branch? (I realize docs doesn't branch the way that k8s/k8s does, but it's so that we can publish continually from master.) Thanks!
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Mar 8, 2018

@Bradamant3 done in #7684, should this be closed or this is merged as well?

@Bradamant3
Copy link
Contributor

Bradamant3 commented Mar 8, 2018

Thanks @soltysh! I can take care of things from here :-)

@Bradamant3 Bradamant3 closed this Mar 8, 2018
@Bradamant3 Bradamant3 mentioned this pull request Mar 8, 2018
Merged
@soltysh soltysh deleted the issue7395 branch March 12, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erictune erictune Awaiting requested review from erictune

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@bradtopol bradtopol

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.10

Development

Successfully merging this pull request may close these issues.

5 participants

@soltysh @k8s-ci-robot @k8sio-netlify-preview-bot @Bradamant3 @bradtopol