Skip to content

kubeadm: add a note about the new --print-join-command flag.#6409

Merged
xiangpengzhao merged 1 commit intokubernetes:release-1.9from
mattmoyer:kubeadm-add-print-join-command-flag
Nov 23, 2017
Merged

kubeadm: add a note about the new --print-join-command flag.#6409
xiangpengzhao merged 1 commit intokubernetes:release-1.9from
mattmoyer:kubeadm-add-print-join-command-flag

Conversation

@mattmoyer
Copy link
Contributor

@mattmoyer mattmoyer commented Nov 22, 2017 •
edited by k8s-reviewable
Loading

This is the change added in kubernetes/kubernetes#56185. This PR should not merge before that one.

The original issue with more context is kubernetes/kubeadm#519.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2017
@mattmoyer mattmoyer force-pushed the kubeadm-add-print-join-command-flag branch from d556131 to f06a963 Compare November 22, 2017 04:22
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 22, 2017

Deploy preview ready!

Built with commit d556131

https://deploy-preview-6409--kubernetes-io-vnext-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 22, 2017 •
edited
Loading

Deploy preview ready!

Built with commit 062bbae

https://deploy-preview-6409--kubernetes-io-vnext-staging.netlify.com

@tengqm tengqm added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2017
@xiangpengzhao xiangpengzhao removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2017
@xiangpengzhao xiangpengzhao changed the title kubeadm: add a note about the new --print-join-command flag. [WIP] kubeadm: add a note about the new --print-join-command flag. Nov 22, 2017
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2017
@xiangpengzhao
Copy link
Contributor

xiangpengzhao commented Nov 22, 2017

@tengqm I remove the manually added do-not-merge/work-in-progress label and modified the PR title with prefix [WIP] to apply the label, in case @mattmoyer don't have the privilege to remove the label manually when the original PR is merged. Then he can modify the PR title by removing the prefix to remove the label.

@xiangpengzhao
Copy link
Contributor

xiangpengzhao commented Nov 22, 2017

We can comment /hold in this case as well. Then the PR will be labeled do-not-merge/hold. Once it's ready to merge, we can comment /hold cancel to remove the label.

@tengqm
Copy link
Contributor

tengqm commented Nov 23, 2017

@xiangpengzhao okay. so long the red light is on.

@xiangpengzhao
Copy link
Contributor

xiangpengzhao commented Nov 23, 2017

@mattmoyer #6326 moves kubeadm.md. This needs rebase.
and since kubernetes/kubernetes#56185 gets merged, it's ok to move do-not-merge now.

@xiangpengzhao xiangpengzhao changed the title [WIP] kubeadm: add a note about the new --print-join-command flag. kubeadm: add a note about the new --print-join-command flag. Nov 23, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2017
@xiangpengzhao
Copy link
Contributor

xiangpengzhao commented Nov 23, 2017

This PR lgtm as per kubernetes/kubernetes#56185.

@mattmoyer
kubeadm: add a note about the new --print-join-command flag.
062bbae 
This is a new flag for the `kubeadm token create` command.
@mattmoyer mattmoyer force-pushed the kubeadm-add-print-join-command-flag branch from f06a963 to 062bbae Compare November 23, 2017 16:32
@mattmoyer
Copy link
Contributor Author

mattmoyer commented Nov 23, 2017

/hold cancel

Rebased, should be ready for another look. Thanks @xiangpengzhao!

@xiangpengzhao
Copy link
Contributor

xiangpengzhao commented Nov 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2017
@xiangpengzhao xiangpengzhao merged commit d26415c into kubernetes:release-1.9 Nov 23, 2017
@fabriziopandini fabriziopandini mentioned this pull request Nov 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@xiangpengzhao xiangpengzhao

@a-mccarthy a-mccarthy

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mattmoyer @k8sio-netlify-preview-bot @xiangpengzhao @tengqm @k8s-ci-robot @a-mccarthy