KEP-5040: Disable git_repo volume driver.#54528
Conversation
|
/cc @xing-yang |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/sig storage |
1d93b5c to
ef1d4dc
Compare
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 83cb58a68e09186b722fa836e240969c51855832 |
| enable the `GitRepoVolumeDriver` | ||
| [feature gate](/docs/reference/command-line-tools-reference/feature-gates/). | ||
|
|
||
| A `gitRepo` volume is an example of a volume plugin. This plugin |
There was a problem hiding this comment.
Also, delete from this line (inclusive) to blank line the start of the next level 3 heading (glusterfs).
There was a problem hiding this comment.
Done. Thanks!
ef1d4dc to
ce49b65
Compare
ce49b65 to
869ed67
Compare
869ed67 to
e9552e6
Compare
|
Hello @vinayakankugoyal 👋, |
|
@xing-yang could you please take another look and provide your LGTM |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 73cb895fbeb1cd0c0eb9d6ec6ab1647259f9644f |
There was a problem hiding this comment.
I think we should drop this too:
You can restrict the use of `gitRepo` volumes in your cluster using
[policies](/docs/concepts/policy/), such as
[ValidatingAdmissionPolicy](/docs/reference/access-authn-authz/validating-admission-policy/).
You can use the following Common Expression Language (CEL) expression as
part of a policy to reject use of `gitRepo` volumes:
`!has(object.spec.volumes) || !object.spec.volumes.exists(v, has(v.gitRepo))`But that can be a separate PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update the documentation for gitRepo volumes to highlight that the gitRepo volume plugin has been disabled and cannot be enabled starting v1.36.
Issue
xref: kubernetes/enhancements#5040