Skip to content

Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys#49602

Merged
k8s-ci-robot merged 4 commits intokubernetes:mainfrom
mochizuki875:add_deprecation_rel_matchlabelkeys_and_mismatchlabelkeys
Feb 16, 2025
Merged

Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys#49602
k8s-ci-robot merged 4 commits intokubernetes:mainfrom
mochizuki875:add_deprecation_rel_matchlabelkeys_and_mismatchlabelkeys

Conversation

@mochizuki875
Copy link
Copy Markdown
Member

@mochizuki875 mochizuki875 commented Jan 31, 2025 •
edited
Loading

Description

Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys.

related:

Special notes for your reviewer

This notification was found when we discussed about PodTopologySpread's matchLabelKeys.(#129480)
But the same can be applied to PodAffinity's matchLabelKeys/mismatchLabelKeys.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@mochizuki875 mochizuki875 mentioned this pull request Jan 31, 2025
Merged
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 31, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit aad1b7c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/679e5944bfd8f6000849bfbc
😎 Deploy Preview https://deploy-preview-49602--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sanposhiho
sanposhiho reviewed Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should:

  • change this PR to only include the mention for PodAffinity.
  • create another PR for PodTopologySpread for dev-1.33 branch so that this wouldn't be reflected onto the website until 1.33 is released.

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jan 31, 2025

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 31, 2025
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jan 31, 2025

/cc @macsko @dom4ha

@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko January 31, 2025 05:49
@mochizuki875 mochizuki875 force-pushed the add_deprecation_rel_matchlabelkeys_and_mismatchlabelkeys branch from 537caae to 14bd4e5 Compare January 31, 2025 06:32
@mochizuki875 mochizuki875 changed the title Add deprecation notices related to matchLabelKeys/mismatchLabelKeys Add deprecation notices related to PodAffinity's matchLabelKeys/mismatchLabelKeys Jan 31, 2025
@mochizuki875
Copy link
Copy Markdown
Member Author

mochizuki875 commented Jan 31, 2025

change this PR to only include the mention for PodAffinity.

I've done.

create another PR for PodTopologySpread for dev-1.33 branch so that this wouldn't be reflected onto the website until 1.33 is released.

I'll submit another PR for PodTopologySpread.

@macsko
Copy link
Copy Markdown
Member

macsko commented Jan 31, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 31, 2025

LGTM label has been added.

DetailsGit tree hash: 827337839dc5abb8cbe2df30f1aace2982410acb

sanposhiho
sanposhiho reviewed Jan 31, 2025
View reviewed changes
Comment thread content/en/docs/concepts/scheduling-eviction/assign-pod-node.md
Comment thread content/en/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2025
@mochizuki875
Copy link
Copy Markdown
Member Author

mochizuki875 commented Jan 31, 2025

I've changed warning callout to caution according to #49607 (review).

sanposhiho
sanposhiho reviewed Jan 31, 2025
View reviewed changes
Comment thread content/en/docs/concepts/scheduling-eviction/assign-pod-node.md Outdated
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jan 31, 2025

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim January 31, 2025 22:02
@mochizuki875 mochizuki875 force-pushed the add_deprecation_rel_matchlabelkeys_and_mismatchlabelkeys branch from 7550bfb to aad1b7c Compare February 1, 2025 17:26
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Feb 1, 2025

Once this PR has been reviewed and has the lgtm label, please assign sftim for approval.

No LGTM yet. Happy for other reviews to happen.
/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from sftim February 1, 2025 22:27
sanposhiho
sanposhiho reviewed Feb 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 2, 2025

LGTM label has been added.

DetailsGit tree hash: e422fbdfd1b9473ff6c20e9481cec35c7625dd0d

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Feb 2, 2025

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim February 2, 2025 14:45
sftim
sftim reviewed Feb 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Comment thread content/en/docs/concepts/scheduling-eviction/assign-pod-node.md

{{< caution >}}
It's not recommended to use `matchLabelKeys` with labels that might be updated directly on pods.
Even if you edit the pod's label that is specified at `matchLabelKeys` **directly**, (that is, not via a deployment),
Copy link
Copy Markdown
Contributor

@sftim sftim Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Deployment should have a capital D; also, we have more than one API for workload management (eg StatefulSet is a thing).

Comment thread content/en/docs/concepts/scheduling-eviction/assign-pod-node.md

{{< caution >}}
It's not recommended to use `mismatchLabelKeys` with labels that might be updated directly on pods.
Even if you edit the pod's label that is specified at `mismatchLabelKeys` **directly**, (that is, not via a deployment),
Copy link
Copy Markdown
Contributor

@sftim sftim Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Deployment should have a capital D; also, we have more than one API for workload management (eg StatefulSet is a thing).

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4762f58 into kubernetes:main Feb 16, 2025
@windsonsea windsonsea mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@reylejano reylejano Awaiting requested review from reylejano

@dom4ha dom4ha Awaiting requested review from dom4ha

@macsko macsko Awaiting requested review from macsko

2 more reviewers

@sftim sftim sftim left review comments

@sanposhiho sanposhiho sanposhiho left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sanposhiho sanposhiho

@macsko macsko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

SIG Scheduling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mochizuki875 @sanposhiho @macsko @k8s-ci-robot @sftim