Skip to content

KEP 4818: PodLifecycleSleepActionAllowZero#48439

Merged
k8s-ci-robot merged 2 commits into
kubernetes:dev-1.32from
sreeram-venkitesh:4818-allow-zero-for-prestop-hook
Nov 22, 2024
Merged

KEP 4818: PodLifecycleSleepActionAllowZero#48439
k8s-ci-robot merged 2 commits into
kubernetes:dev-1.32from
sreeram-venkitesh:4818-allow-zero-for-prestop-hook

Conversation

@sreeram-venkitesh

@sreeram-venkitesh sreeram-venkitesh commented Oct 19, 2024

Copy link
Copy Markdown
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 19, 2024
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Oct 19, 2024
Closed
14 tasks
@sreeram-venkitesh

sreeram-venkitesh commented Oct 19, 2024

Copy link
Copy Markdown
Member Author

Placeholder PR for the KEP, will come back to this next week.

@netlify

netlify Bot commented Oct 19, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 49e252c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673b54c1b67b8d00072ea5cf
😎 Deploy Preview https://deploy-preview-48439--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kannon92

kannon92 commented Oct 20, 2024

Copy link
Copy Markdown
Contributor

I think this needs to target dev-1.32.

@sreeram-venkitesh

sreeram-venkitesh commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

@kannon92 Ah I missed that, thanks for pointing it out Kevin!

@sreeram-venkitesh sreeram-venkitesh changed the base branch from main to dev-1.32 October 21, 2024 02:47
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2024
@sreeram-venkitesh sreeram-venkitesh force-pushed the 4818-allow-zero-for-prestop-hook branch from 92ef246 to 1ea5b20 Compare October 21, 2024 02:49
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes language/bn Issues or PRs related to Bengali language language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/hi Issues or PRs related to Hindi language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language labels Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 18, 2024
@sreeram-venkitesh

sreeram-venkitesh commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

/remove-area blog localization release-eng web-development
/remove-language bn de es fr hi id it ja ko pl pt ru uk vi zh
/remove-sig release

@k8s-ci-robot k8s-ci-robot removed area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language labels Nov 18, 2024
@k8s-ci-robot

k8s-ci-robot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

@sreeram-venkitesh: Those labels are not set on the issue: area/web-development, language/bn, language/fr, language/hi, language/it, language/pl, language/uk, language/vi

Details

In response to this:

/remove-area blog localization release-eng web-development
/remove-language bn de es fr hi id it ja ko pl pt ru uk vi zh
/remove-sig release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@windsonsea

windsonsea commented Nov 18, 2024

Copy link
Copy Markdown
Member

/remove-language de es id ja ko pt ru zh

@sreeram-venkitesh

sreeram-venkitesh commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

This PR is now ready for review! 🎉

CC: @chanieljdan

@tengqm

tengqm commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chanieljdan

chanieljdan commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

Hi @sreeram-venkitesh looking good on this one, do you know if we could get a technical review from someone in sig-node? Once they give their LGTM then this can get merged. Thanks!

@kannon92

kannon92 commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

LGTM from sig-node side.

@sreeram-venkitesh

sreeram-venkitesh commented Nov 22, 2024

Copy link
Copy Markdown
Member Author

Thanks @kannon92!

@chanieljdan

chanieljdan commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

Technical LGTM provided above, as well as sig-docs approval

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 12c1cb223764bce9652a4159a6defd98d9c78b5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

@tengqm tengqm Awaiting requested review from tengqm

@reylejano reylejano Awaiting requested review from reylejano

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chanieljdan chanieljdan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.32

Development

Successfully merging this pull request may close these issues.

8 participants

@sreeram-venkitesh @kannon92 @chanieljdan @jihoon-seo @k8s-ci-robot @windsonsea @tengqm @sftim