KEP-4420: Retry Generate Name: Promote to beta#46983
Merged
k8s-ci-robot merged 1 commit intoJun 26, 2024
Merged
Conversation
12 tasks
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
T-Lakshmi
reviewed
Jun 26, 2024
T-Lakshmi
left a comment
Contributor
There was a problem hiding this comment.
Changes looks fine to me.
/lgtm
Contributor
|
LGTM label has been added. DetailsGit tree hash: e8109365e486413b54780c6b46a2690261cd1eee |
Contributor
|
Here is the Preview page. |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a user visible feature. The change is that name generation is retried automatically by the apiserver if the randomly generated hash collides an existing name. Name generation failures can still happen, and happen with the same error, but are far more rare.
For this reason, only a feature gate is being added to the documentation.