Skip to content

update hpa with custom metrics#4344

Closed
zouyee wants to merge 1 commit intokubernetes:masterfrom
zouyee:obkca
Closed

update hpa with custom metrics#4344
zouyee wants to merge 1 commit intokubernetes:masterfrom
zouyee:obkca

Conversation

@zouyee
Copy link
Member

@zouyee zouyee commented Jul 11, 2017

update hpa with custom metrics which has been updated with v1 version


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2017
With Horizontal Pod Autoscaling, Kubernetes automatically scales the number of pods
in a replication controller, deployment or replica set based on observed CPU utilization
(or, with alpha support, on some other, application-provided metrics).
(or, with (custom metrics)[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md] support, on some other, application-provided metrics).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Parenthesis are wrong - name should be in [] and link in ()
  • why do you remove information about this feature being alpha?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can use url: http://git.k8s.io/community/contributors/design-proposals/custom-metrics-api.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of linking to developer design proposals from the official user docs, and this removes information about the support level. I'm all for improved user docs, but we should add actual user docs, not links to developer proposals.

With Horizontal Pod Autoscaling, Kubernetes automatically scales the number of pods
in a replication controller, deployment or replica set based on observed CPU utilization
(or, with alpha support, on some other, application-provided metrics).
(or, with (custom metrics)[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md] support, on some other, application-provided metrics).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can use url: http://git.k8s.io/community/contributors/design-proposals/custom-metrics-api.md

@chenopis
Copy link
Contributor

@zouyee Can you address the comments and merge conflict? thx

With Horizontal Pod Autoscaling, Kubernetes automatically scales the number of pods
in a replication controller, deployment or replica set based on observed CPU utilization
(or, with alpha support, on some other, application-provided metrics).
(or, with (custom metrics)[https://github.com/kubernetes/community/blob/master/contributors/design-proposals/custom-metrics-api.md] support, on some other, application-provided metrics).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangxiaoyu-zidif
Copy link
Contributor

@zouyee could you rebase this PR and fix it?

@steveperry-53
Copy link
Contributor

Ping @zouyee

@zhangxiaoyu-zidif
Copy link
Contributor

ping @zouyee
could you resovle the conflict?

@xiangpengzhao xiangpengzhao added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2017
@steveperry-53
Copy link
Contributor

In the interest of moving this small change forward, I'm going to create a duplicate.
Duplicate of #6023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants