Skip to content

Clarify lack of upgrade order for components#35572

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
shannonxtreme:clarify-upgrade-order
Aug 3, 2022
Merged

Clarify lack of upgrade order for components#35572
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
shannonxtreme:clarify-upgrade-order

Conversation

@shannonxtreme
Copy link
Copy Markdown
Contributor

@shannonxtreme shannonxtreme commented Jul 30, 2022

Fixes #12323

Adds a sentence to say that there's no specific upgrade order required for kube-controller-manager, kube-scheduler, and cloud-controller-manager as long as kube-apiserver is upgraded first.

/sig docs
/language en
/cc @liggitt @lavalamp

@k8s-ci-robot k8s-ci-robot requested review from lavalamp and liggitt July 30, 2022 10:48
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 30, 2022
@shannonxtreme shannonxtreme force-pushed the clarify-upgrade-order branch from 04271b6 to cbb4644 Compare July 30, 2022 10:54
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 30, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 04271b6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62e50c745b334c0009c81c62
😎 Deploy Preview https://deploy-preview-35572--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link
Copy Markdown

netlify bot commented Jul 30, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 93c2f67
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62e7de720897560009b5f275
😎 Deploy Preview https://deploy-preview-35572--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

liggitt
liggitt reviewed Aug 1, 2022
View reviewed changes
@shannonxtreme @liggitt
Clarify lack of upgrade order for components
93c2f67 
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
@shannonxtreme shannonxtreme force-pushed the clarify-upgrade-order branch from cbb4644 to 93c2f67 Compare August 1, 2022 14:08
@shannonxtreme shannonxtreme requested a review from liggitt August 1, 2022 14:09
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Aug 1, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 1, 2022

LGTM label has been added.

DetailsGit tree hash: 756f3c9255b55eaa8c28eddee7e3cd8778265045

@lavalamp
Copy link
Copy Markdown
Contributor

lavalamp commented Aug 1, 2022

/lgtm
/approve

Can you edit (in a followup?) perhaps line 116 to make it explicit that this means webhooks must be upgraded first?

Webhooks need to be ahead of apiserver and tolerate requests from apiserver version N and N-1.

@reylejano
Copy link
Copy Markdown
Member

reylejano commented Aug 3, 2022

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 17c47a8 into kubernetes:main Aug 3, 2022
@shannonxtreme shannonxtreme deleted the clarify-upgrade-order branch August 4, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@lavalamp lavalamp

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clarify kube-controller-manager/kube-scheduler skew support and upgrade order

5 participants

@shannonxtreme @liggitt @k8s-ci-robot @lavalamp @reylejano