Skip to content

Mark blogs older than a year as outdated#31594

Merged
k8s-ci-robot merged 6 commits into
kubernetes:mainfrom
chalin:chalin-outdated-blog-feat-2022-02-01
Feb 2, 2022
Merged

Mark blogs older than a year as outdated#31594
k8s-ci-robot merged 6 commits into
kubernetes:mainfrom
chalin:chalin-outdated-blog-feat-2022-02-01

Conversation

@chalin

@chalin chalin commented Feb 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview, for example, see:

Screenshot:

image

/cc @nate-double-u

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 1, 2022
@netlify

netlify Bot commented Feb 1, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 1a88ffd

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61fa8f6207d370000841d0a8

😎 Browse the preview: https://deploy-preview-31594--kubernetes-io-main-staging.netlify.app

sftim
sftim reviewed Feb 1, 2022
View reviewed changes

@sftim sftim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin thank you for this!

/lgtm

I've made some suggestions to make the work easier for localization teams, and to lay the ground if we want to use a more subtle style for the deprecation notice.

What do you think?

Comment thread data/i18n/en/en.toml Outdated
Comment thread layouts/partials/deprecation-warning.html Outdated
Comment thread data/i18n/en/en.toml Outdated
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@k8s-ci-robot

k8s-ci-robot commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: ffdf4fe8e8a2e6f427bfd11691ad2b007d4e0d89

@sftim

sftim commented Feb 1, 2022

Copy link
Copy Markdown
Contributor

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Feb 1, 2022
@chalin
Add class blog-outdated-warning
659dd4b 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim February 1, 2022 20:41
@chalin
page -> article
d7b651a 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 1, 2022
@chalin chalin force-pushed the chalin-outdated-blog-feat-2022-02-01 branch from 8326bc6 to 662be2b Compare February 1, 2022 20:56
@chalin chalin force-pushed the chalin-outdated-blog-feat-2022-02-01 branch from 662be2b to 6de4f5b Compare February 1, 2022 20:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 1, 2022
@chalin

chalin commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

Great suggestions @sftim, thanks! I've updated the PR. PTAL

chalin
chalin commented Feb 1, 2022
View reviewed changes
Comment thread layouts/partials/deprecation-warning.html Outdated
Comment on lines +13 to +14
{{ $title := .Param "outdated_blog.title" | default (T "outdated_blog_title") -}}
{{ $msg := .Param "outdated_blog.message" | default (T "outdated_blog_over_one_year_old") -}}

@chalin chalin Feb 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I'll pull out the .Param "outdated_blog.* parts, since it isn't fully functional (at least not as I envision it) and it isn't needed for marking blogs that are a year or older. (I'll do that tomorrow.)

@chalin

chalin commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

@sftim @nate-double-u : final cleanup done, this is ready for your review.

sftim
sftim reviewed Feb 2, 2022
View reviewed changes

@sftim sftim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @chalin

@sftim

sftim commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

/area blog

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2022
@k8s-ci-robot

k8s-ci-robot commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 2aeb83be5d8c69ce10a011196354a06bc8da7998

@k8s-ci-robot

k8s-ci-robot commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5580f5c into kubernetes:main Feb 2, 2022
@chalin chalin deleted the chalin-outdated-blog-feat-2022-02-01 branch February 2, 2022 18:53
@chalin

chalin commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

@sftim @nate-double-u - Btw, I did want to mention one minor (IMHO) glitch: the Japanese blog landing page gets marked as outdated, presumable because it contains a single blog entry that is itself outdated — see https://kubernetes.io/ja/blog/

IMHO, this is a docsy (or Hugo) glitch, no worth writing custom layout code for. This might be fixed in a more recent version of Docsy. Let me know if you're ok with this glitch or whether you'd like for me to investigate further.

@nate-double-u

nate-double-u commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

That's probably worth opening an issue for, even if we mark it as an upstream problem.

This was referenced Feb 2, 2022
Closed
Closed
@chalin

chalin commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

Done: #31601

@sftim sftim mentioned this pull request Feb 8, 2022
Closed
@sftim sftim mentioned this pull request Feb 17, 2022
Closed
@chalin chalin mentioned this pull request Feb 24, 2022
Closed
4 tasks
@chalin chalin mentioned this pull request Mar 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

4 participants

@chalin @k8s-ci-robot @sftim @nate-double-u