Skip to content

Hugo improvements#29504

Merged
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
jimangel:hugo-improvements
Aug 23, 2021
Merged

Hugo improvements#29504
k8s-ci-robot merged 2 commits intokubernetes:mainfrom
jimangel:hugo-improvements

Conversation

@jimangel
Copy link
Copy Markdown
Member

@jimangel jimangel commented Aug 22, 2021 •
edited
Loading

This PR was created to address the performance of Hugo. I would love to have a few folks check full functionality.

By setting params.ui.sidebar_cache_limit to 1, the build time went from 1m30s to 15s locally and 5m45s to 45s in Netlify!!! (details)

While I was making tweaks, I wanted to remove the WARNING: calling IsSet with unsupported type "invalid" (<nil>) will always return false. Fixed via docsy, so I upgraded the module in the second commit following my old instructions.

Lastly, I tested this on the latest build of Hugo and updated netlify.toml to match.

Potentially fixes: #29429

Site preview: https://deploy-preview-29504--kubernetes-io-main-staging.netlify.app

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 22, 2021
@jimangel
Copy link
Copy Markdown
Member Author

jimangel commented Aug 22, 2021

Old build (current published one on main):

12:18:54 PM: (build.command completed in 5m 45.7s)

This build:

3:11:23 PM: (build.command completed in 46.7s)

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 22, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: e01f70d

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6122af1366766a0007b04f9f

😎 Browse the preview: https://deploy-preview-29504--kubernetes-io-main-staging.netlify.app

@zacharysarah
Copy link
Copy Markdown
Contributor

zacharysarah commented Aug 22, 2021

Wow, that’s amazing! 🤩 Thanks for finding a solution, @jimangel!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 22, 2021

LGTM label has been added.

DetailsGit tree hash: d40d479abb78d6ce6d24836d0a1f30e30c2ad2df

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Aug 23, 2021

/approve
/hold

in case further testing is wanted

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Aug 23, 2021

anyone: feel free to unhold

@jimangel
Copy link
Copy Markdown
Member Author

jimangel commented Aug 23, 2021

Let it rip! 🚀
/unhold
/woof
Thanks @sftim!

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 23, 2021

@jimangel: dog image

Details

In response to this:

Let it rip! 🚀
/unhold
/woof
Thanks @sftim!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit e220769 into kubernetes:main Aug 23, 2021
@nate-double-u nate-double-u mentioned this pull request Aug 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees

@zacharysarah zacharysarah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generating this site takes an alarming amount of resources.

4 participants

@jimangel @zacharysarah @k8s-ci-robot @sftim