Skip to content

Update eviction example to use policy/v1#27810

Merged
k8s-ci-robot merged 1 commit intokubernetes:dev-1.22from
liggitt:eviction-v1
May 26, 2021
Merged

Update eviction example to use policy/v1#27810
k8s-ci-robot merged 1 commit intokubernetes:dev-1.22from
liggitt:eviction-v1

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Apr 29, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot requested a review from mortent April 29, 2021 15:35
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 29, 2021
@liggitt liggitt mentioned this pull request Apr 29, 2021
Closed
12 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 29, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 176d236

https://deploy-preview-27810--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Apr 29, 2021

I think this should target the branch dev-1.22 - targeting master would mean we want this change in the live documentation right away.

@liggitt liggitt changed the base branch from master to dev-1.22 April 29, 2021 16:04
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2021
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

k8sio-netlify-preview-bot commented Apr 29, 2021

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit f081886

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/608ad943215bf10008b1fe6a

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Apr 29, 2021

done, didn't realize the 1.22 branch was already available

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2021
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented Apr 29, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@reylejano
Copy link
Copy Markdown
Member

reylejano commented Apr 29, 2021

/milestone 1.22
/cc @PI-Victor

@k8s-ci-robot k8s-ci-robot requested a review from PI-Victor April 29, 2021 16:57
@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Apr 29, 2021
@PI-Victor PI-Victor mentioned this pull request May 6, 2021
Closed
@PI-Victor
Copy link
Copy Markdown
Contributor

PI-Victor commented May 12, 2021

/unassign
/assign @chrisnegus
/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label May 12, 2021
@sftim
Copy link
Copy Markdown
Contributor

sftim commented May 12, 2021

LGTM

irvifa
irvifa reviewed May 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 18, 2021

LGTM label has been added.

DetailsGit tree hash: 7d0f67489caf30f6c3e58ae949620b36da6bc968

@PI-Victor
Copy link
Copy Markdown
Contributor

PI-Victor commented May 26, 2021

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7d631e4 into kubernetes:dev-1.22 May 26, 2021
@liggitt liggitt deleted the eviction-v1 branch August 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mortent mortent Awaiting requested review from mortent

2 more reviewers

@irvifa irvifa irvifa left review comments

@PI-Victor PI-Victor PI-Victor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@irvifa irvifa

@chrisnegus chrisnegus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.22

Development

Successfully merging this pull request may close these issues.

8 participants

@liggitt @sftim @k8sio-netlify-preview-bot @reylejano @PI-Victor @k8s-ci-robot @irvifa @chrisnegus