Skip to content

Fix API reference doc for 1.16#18587

Merged
k8s-ci-robot merged 1 commit intokubernetes:release-1.16from
tengqm:fix-1.16-apiref
Jan 10, 2020
Merged

Fix API reference doc for 1.16#18587
k8s-ci-robot merged 1 commit intokubernetes:release-1.16from
tengqm:fix-1.16-apiref

Conversation

@tengqm
Copy link
Copy Markdown
Contributor

@tengqm tengqm commented Jan 10, 2020

For some unknown reasons, we are displaying "1.17.0" as the API version in the release-1.16 branch. The error was introduced in #16569. This PR refreshes the reference doc by showing the correct version. The
updated reference also contains the following improvements:

  • responses from an API are now sorted by their code;
  • the left navigation bar can be horizontally scrolled if text is too long;
  • the fixes to the examples are back ported to release-1.16.

For some unknown reasons, we are displaying "1.17.0" as the API version
in the release-1.16 branch. The error was introduced in kubernetes#16569.
This PR refreshes the reference doc by showing the correct version. The
updated reference also contains the following improvements:

- responses from an API are now sorted by their code;
- the left navigation bar can be horizontally scrolled if text is too long;
- the fixes to the examples are backported to release-1.16.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2020
@zacharysarah
Copy link
Copy Markdown
Contributor

Thanks for fixing this, @tengqm! Also for weighing in on kubernetes/kubernetes#84654.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit e01fd4d into kubernetes:release-1.16 Jan 10, 2020
@tengqm tengqm deleted the fix-1.16-apiref branch March 6, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants