Skip to content

Initial commit for Ukrainian localization#18569

Merged
k8s-ci-robot merged 3 commits intokubernetes:dev-1.17-uk.1from
anastyakulyk:init_uk_l10n
Jan 13, 2020
Merged

Initial commit for Ukrainian localization#18569
k8s-ci-robot merged 3 commits intokubernetes:dev-1.17-uk.1from
anastyakulyk:init_uk_l10n

Conversation

@MaxymVlasov
Copy link
Copy Markdown
Member

@MaxymVlasov MaxymVlasov commented Jan 9, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 9, 2020

Welcome @MaxymVlasov!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 9, 2020
@Potapy4
Copy link
Copy Markdown
Contributor

Potapy4 commented Jan 9, 2020

Я також можу допомогти з ревью PR'ов 🙂

sftim
sftim reviewed Jan 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heartening to see a strong start towards adding another localization.

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 10, 2020

@Potapy4 feel free to /lgtm if it does indeed look good to you.

@MaxymVlasov MaxymVlasov mentioned this pull request Jan 10, 2020
Closed
6 tasks
@anastyakulyk anastyakulyk mentioned this pull request Jan 10, 2020
Closed
6 tasks
@MaxymVlasov
Copy link
Copy Markdown
Member Author

MaxymVlasov commented Jan 10, 2020

@Potapy4, @sftim would you like to be added to sig-docs-uk-reviews and participate in reviews future PRs?

@MaxymVlasov MaxymVlasov mentioned this pull request Jan 10, 2020
Merged
@Potapy4
Copy link
Copy Markdown
Contributor

Potapy4 commented Jan 10, 2020

would you like to be added to sig-docs-uk-reviews and participate in reviews future PRs?

yep, I'm on it 🙂

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@MaxymVlasov
Copy link
Copy Markdown
Member Author

MaxymVlasov commented Jan 10, 2020

Cool! If you'd like, you can also join #kubernetes-docs-uk Slack channel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@Potapy4
Copy link
Copy Markdown
Contributor

Potapy4 commented Jan 11, 2020

/verify-owners
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2020
@Potapy4 Potapy4 mentioned this pull request Jan 11, 2020
Merged
@MaxymVlasov
Copy link
Copy Markdown
Member Author

MaxymVlasov commented Jan 11, 2020

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 11, 2020
@butuzov
Copy link
Copy Markdown
Contributor

butuzov commented Jan 11, 2020

і понеслось... !

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 11, 2020 •
edited
Loading

Re: #18569 (comment)

@MaxymVlasov I can just about read Russian and I can make out some Ukrainian because the two languages are similar. I'm not up to providing regular positive reviews.
(I can provide linting-style feedback, because those errors stand out even if I cannot do translation work myself).

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 11, 2020

Would you like a new branch created for Ukrainian localization, as per branching strategy? If so, I'm sure that can happen.

@MaxymVlasov
Copy link
Copy Markdown
Member Author

MaxymVlasov commented Jan 13, 2020 •
edited
Loading

@sftim yes, separate branch can be helpful, I will ask about it Roy Lenferink in nearest future.
Also, looks like all OK. For go forward and merge PR, we need /approve from your side?

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 13, 2020

It's fine to work on a branch and build a series of changes that together meet the minimum requirements.

At the moment, https://deploy-preview-18569--kubernetes-io-master-staging.netlify.com/uk/ does not look ready for merge.

I will ask on Slack about getting a new branch.

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 13, 2020

@kubernetes/sig-docs-l10n-admins, please create a new branch for Ukrainian / Українська (uk) localization.

@anastyakulyk
Copy link
Copy Markdown
Contributor

anastyakulyk commented Jan 13, 2020

Re: #18569 (comment)
@sftim many thanks for your feedback! Do I understand it right that to have our localization PR merged we also need to translate the content from the front page? Could you please specify where can we find those files? Because they are not mentioned in minimum content requirements https://kubernetes.io/docs/contribute/localization/#minimum-required-content

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 13, 2020

@anastyakulyk please see the table at https://kubernetes.io/docs/contribute/localization/#translating-content
If you work on a localization branch you need all of those minimum things before the branch can merge into master.

…and there is a localization branch now, so you can open pull requests that target dev-1.17-uk.1
@MaxymVlasov would you be OK to either change the target branch for this PR, or to open a new one that targets dev-1.17-uk.1?

@anastyakulyk
Copy link
Copy Markdown
Contributor

anastyakulyk commented Jan 13, 2020

#18569 (comment)
@sftim thanks, got it!

@MaxymVlasov MaxymVlasov changed the base branch from master to dev-1.17-uk.1 January 13, 2020 15:47
@MaxymVlasov
Copy link
Copy Markdown
Member Author

MaxymVlasov commented Jan 13, 2020

@sftim thanks. I changed base branch to dev-1.17-uk.1.

Also, I have a little question about review and PR flow. We need translate all described in translating content by this PR or can create many non-big PR's which after /lgtm can be merged into dev-1.17-uk.1 branch?

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 13, 2020

This PR is enough to kick things off on the branch for Ukrainian localization.

When you're ready, you can take everything from dev-1.17-uk.1, squash it, and propose a PR to merge into master.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2dfbdc2 into kubernetes:dev-1.17-uk.1 Jan 13, 2020
@MaxymVlasov MaxymVlasov deleted the init_uk_l10n branch January 13, 2020 19:12
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Apr 11, 2020

/language uk

@k8s-ci-robot k8s-ci-robot added the language/uk Issues or PRs related to Ukrainian language label Apr 11, 2020
@OleksaBaida
Copy link
Copy Markdown

OleksaBaida commented Jan 25, 2021

Hello, guys

is there any TL;DR like howto/page/guide for wannabes who looking how to participate in the translation?

@butuzov
Copy link
Copy Markdown
Contributor

butuzov commented Jan 25, 2021

You can join https://slack.kubernetes.io/ chan #kubernetes-docs-uk

@MaxymVlasov
Copy link
Copy Markdown
Member Author

MaxymVlasov commented Jan 26, 2021

@OleksaBaida please check issue below, it have minimum for start contributing
#20786

@OleksaBaida
Copy link
Copy Markdown

OleksaBaida commented Jan 31, 2021

thanks @MaxymVlasov . Looks just what I was looking for. Great job!

@seokho-son seokho-son mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredbhatti jaredbhatti Awaiting requested review from jaredbhatti

@simplytunde simplytunde Awaiting requested review from simplytunde

1 more reviewer

@sftim sftim sftim left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Potapy4 Potapy4

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/uk Issues or PRs related to Ukrainian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MaxymVlasov @k8s-ci-robot @Potapy4 @sftim @butuzov @anastyakulyk @OleksaBaida