Skip to content

Add kubectl diff to common operations#18483

Closed
zhouya0 wants to merge 1 commit intokubernetes:masterfrom
zhouya0:add_kubectl_diff_to_common_operations
Closed

Add kubectl diff to common operations#18483
zhouya0 wants to merge 1 commit intokubernetes:masterfrom
zhouya0:add_kubectl_diff_to_common_operations

Conversation

@zhouya0
Copy link
Copy Markdown
Contributor

@zhouya0 zhouya0 commented Jan 6, 2020

Add kubectl diff to common operations as kubectl diff is GA.
Part of kubernetes/kubernetes#86525

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 6, 2020
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jan 6, 2020

/kind cleanup
/sig cli

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Jan 6, 2020
@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Jan 8, 2020

Hi @apelisse can you serve as the technical reviewer for this PR? Simply add a /lgtm if you are happy with the technical description and I'll take care of the rest.
/cc @apelisse

@k8s-ci-robot k8s-ci-robot requested a review from apelisse January 8, 2020 04:16
@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Jan 8, 2020

/assign

apelisse
apelisse reviewed Jan 8, 2020
View reviewed changes
content/en/docs/reference/kubectl/overview.md Outdated
kubectl logs -f <pod-name>
```

`kubectl diff` - Diff configurations with the current online configuration.
Copy link
Copy Markdown
Member

@apelisse apelisse Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how this conversation finishes: https://github.com/kubernetes/website/pull/18481/files#r364340730

@zhouya0 zhouya0 force-pushed the add_kubectl_diff_to_common_operations branch from a8c43e1 to 4597b06 Compare January 10, 2020 03:58
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bradtopol
You can assign the PR to them by writing /assign @bradtopol in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apelisse
Copy link
Copy Markdown
Member

apelisse commented Jan 10, 2020

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@zhouya0
Copy link
Copy Markdown
Contributor Author

zhouya0 commented Jan 13, 2020

@tengqm please review this, thanks!

@zhouya0
Copy link
Copy Markdown
Contributor Author

zhouya0 commented Jan 13, 2020

And also please review this PR @jimangel, really thanks !

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jan 13, 2020

content looks good to me, but I don't know whether it is already GA'ed in 1.17 or GA is 1.18 thing.

@zhouya0
Copy link
Copy Markdown
Contributor Author

zhouya0 commented Jan 13, 2020 •
edited
Loading

content looks good to me, but I don't know whether it is already GA'ed in 1.17 or GA is 1.18 thing.

It gonna be GA in 1.18, so should i left "Beta" cause 1.18 is not released yet?

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jan 13, 2020

@zhouya0 docs should not go ahead of code landings. If for 1.17 it is still a beta, we should not drop it from the master branch. When the code has landed and we are sure it is gonna be part of 1.18, you can propose a PR to the dev-1.18 branch, possibly with a pointer to the upstream PR.

@apelisse
Copy link
Copy Markdown
Member

apelisse commented Jan 13, 2020

you can propose a PR to the dev-1.18 branch

Exaclty, can you rebase your PR on top of dev-1.18 and re-submit? Your PR is really appreciated and definitely belongs there, thanks!

@zhouya0 zhouya0 mentioned this pull request Jan 14, 2020
Merged
@zhouya0
Copy link
Copy Markdown
Contributor Author

zhouya0 commented Jan 14, 2020

@apelisse Thanks! I got it, i will close this PR and sunmmit another PR. #18665

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 14, 2020

@zhouya0: Closed this PR.

Details

In response to this:

@apelisse Thanks! I got it, i will close this PR and sunmmit another PR. #18665

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hw-qiaolei hw-qiaolei Awaiting requested review from hw-qiaolei

@tengqm tengqm Awaiting requested review from tengqm

1 more reviewer

@apelisse apelisse apelisse left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@apelisse apelisse

@bradtopol bradtopol

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhouya0 @sftim @bradtopol @k8s-ci-robot @apelisse @tengqm @lesszyao