Update DaemonSet scheduling version inconsistency#17476
Update DaemonSet scheduling version inconsistency#17476christophercarney wants to merge 2 commits intokubernetes:masterfrom christophercarney:patch-2
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 79a23f0 https://deploy-preview-17476--kubernetes-io-master-staging.netlify.com |
|
@christophercarney you might also have some thoughts on rewording https://github.com/kubernetes/website/pull/16885/files#diff-8342a130ee45184367af9dca4b6d6f2aR1 |
|
@sftim Made a few changes according to our discussion. Kept the rewording but moved the motivation for why DaemonSet controller is no longer the default behavior to the DaemonSet controller section to (hopefully) make it more clear both why default scheduler is the default behavior and that it is indeed the default. |
sftim
left a comment
There was a problem hiding this comment.
I'm happy with these changes.
Bear in mind that this will go out of date when v1.17 is released (v1.12 will no longer be supported, so there's then a task about cleanup & simplifying).
|
I’ll take note of that and circle back around to this at that time. /assign @tfogo |
|
This didn't get approved as yet. |
|
@christophercarney: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @christophercarney , Do you have time to follow-up on this PR (and rebase as well)? |
|
@christophercarney I'm going to close this PR. Please feel free to rebase your work against master and open a new similar pull request with the same description. /close |
|
@sftim: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #17336
Check the issue for more details but in short: an update was made to the header specifying the default behavior when it switched over in 1.12 without modifying the intro paragraph (which still reflects that DaemonSet controller is the default scheduling behavior)