Skip to content

fixed yaml block so it renders#17259

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jimangel:yaml-fix
Oct 29, 2019
Merged

fixed yaml block so it renders#17259
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
jimangel:yaml-fix

Conversation

@jimangel
Copy link
Copy Markdown
Member

@jimangel jimangel commented Oct 29, 2019

If a code block is underneath a bullet, and not properly indented, it does not render. (potentially a more strict check was introduced with blackfriday v1.5.3, that came with the Hugo 0.57.x upgrade)

Indenting blocks underneath bullets fixes this problem.

More context: https://kubernetes.slack.com/archives/C1J0BPD2M/p1572286360131000

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 29, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 29, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 29, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 61b1c94

https://deploy-preview-17259--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Copy Markdown
Contributor

/assign

@bradtopol
Copy link
Copy Markdown
Contributor

Great catch! Renders much better now! :-)
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 647b4cd into kubernetes:master Oct 29, 2019
@kbhawkey kbhawkey mentioned this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants