Skip to content

change the contianer runtime link to the correct id#17245

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
lojies:node_cri20191028
Oct 30, 2019
Merged

change the contianer runtime link to the correct id#17245
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
lojies:node_cri20191028

Conversation

@lojies
Copy link
Copy Markdown
Contributor

@lojies lojies commented Oct 28, 2019

The services on a node include the container runtime, kubelet and kube-proxy.
in page :https://kubernetes.io/docs/concepts/architecture/nodes/
When clicking the contianer runtime, it just links to
https://kubernetes.io/docs/concepts/overview/components/#node-components.
Make it linksto the container runtime.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 28, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 28, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 92a3c5b

https://deploy-preview-17245--kubernetes-io-master-staging.netlify.com

savitharaghunathan
savitharaghunathan reviewed Oct 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lojies, For consistency can you also update the container runtime link in https://deploy-preview-17245--kubernetes-io-master-staging.netlify.com//docs/concepts/architecture/nodes/#node-capacity ?

@lojies
Copy link
Copy Markdown
Contributor Author

lojies commented Oct 29, 2019

@savitharaghunathan, i have changed these to the same.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Oct 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 20694c7 into kubernetes:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

1 more reviewer

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tengqm tengqm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lojies @tengqm @k8s-ci-robot @savitharaghunathan