Skip to content

Update horizontal-pod-autoscale-walkthrough.md#17206

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
tengfei86:patch-2
Oct 30, 2019
Merged

Update horizontal-pod-autoscale-walkthrough.md#17206
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
tengfei86:patch-2

Conversation

@tengfei86
Copy link
Copy Markdown
Contributor

@tengfei86 tengfei86 commented Oct 26, 2019

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17

For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh

For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 26, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 26, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a34c9e0

https://deploy-preview-17206--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 26, 2019

@zparnold Are you familiar with this enough to do a technical review? I think you are. If not let me know and I'll find a technical reviewer. Thanks!

/assign @zparnold

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Oct 27, 2019

@tengfei86 I don't see any explanation for what this pull request fixes / improves.

Can you write a note (ideally, in the commit message) to describe why you're making that change? If you're not sure how to do that, reply here and someone else ought to be able to help tweak it.

tengqm
tengqm reviewed Oct 28, 2019
View reviewed changes
content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md
name: cpu
target:
type: AverageUtilization
type: Utilization
Copy link
Copy Markdown
Contributor

@tengqm tengqm Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.16/#metrictarget-v2beta2-autoscaling,
The type should be one of Utilization, Value, or AverageValue.
So this change makes sense to me.

tengqm
tengqm reviewed Oct 28, 2019
View reviewed changes
content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md
name: main-route
target:
kind: Value
type: Value
Copy link
Copy Markdown
Contributor

@tengqm tengqm Oct 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.16/#metrictarget-v2beta2-autoscaling,
the target field is a MetricTarget object, which can have fields like averageUtilization, averageValue, type and value. 'kind' is obviously not the right property name.
This change makes sense to me.

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Oct 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Oct 30, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit f65a6fe into kubernetes:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@tengqm tengqm

@zparnold zparnold

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tengfei86 @bradtopol @sftim @tengqm @k8s-ci-robot @zparnold