Skip to content

Typo: Remove duplicate reference to awsElasticBlockStore#17135

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wmcg:patch-1
Oct 28, 2019
Merged

Typo: Remove duplicate reference to awsElasticBlockStore#17135
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wmcg:patch-1

Conversation

@wmcg
Copy link
Copy Markdown
Contributor

@wmcg wmcg commented Oct 23, 2019

In the list of in-tree volume plugins awsElasticBlockStore is listed twice, this PR removes the duplicate.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 23, 2019

Welcome @wmcg!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 23, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 23, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 23, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7718d71

https://deploy-preview-17135--kubernetes-io-master-staging.netlify.com

@wmcg
Copy link
Copy Markdown
Contributor Author

wmcg commented Oct 23, 2019

/check-cla

@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 23, 2019

/assign

@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 23, 2019

Hi @wmcg Thank you for your contribution. Please sign the CLA so we can accept your PR for review.

@wmcg
Copy link
Copy Markdown
Contributor Author

wmcg commented Oct 24, 2019

/check-cla

1 similar comment
@wmcg
Copy link
Copy Markdown
Contributor Author

wmcg commented Oct 24, 2019

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 24, 2019
@wmcg
Copy link
Copy Markdown
Contributor Author

wmcg commented Oct 24, 2019

Phew, got there in the end!

michmike
michmike approved these changes Oct 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@michmike michmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Oct 28, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michmike, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit fbca7bb into kubernetes:master Oct 28, 2019
@wmcg wmcg deleted the patch-1 branch October 28, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrickLang PatrickLang Awaiting requested review from PatrickLang

1 more reviewer

@michmike michmike michmike approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michmike michmike

@bradtopol bradtopol

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wmcg @k8s-ci-robot @bradtopol @tengqm @michmike