Skip to content

remove SEE ALSO section from command include files#17123

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kbhawkey:fix-kubeadm-cmd-link
Oct 24, 2019
Merged

remove SEE ALSO section from command include files#17123
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kbhawkey:fix-kubeadm-cmd-link

Conversation

@kbhawkey
Copy link
Copy Markdown
Contributor

- For further information, see issue kubernetes#16998.
- Regenerated files using,
  kubernetes/website/update-imported-docs/update-imported-docs
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 22, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor Author

/cc @neolit123 . Would you have time to review the files?

@neolit123
Copy link
Copy Markdown
Member

@kbhawkey
/lgtm
/hold

feel free to remove the hold but ideally @tengqm should confirm if the generator can skip generating these sections for 1.17.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 22, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d7be1ad

https://deploy-preview-17123--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Copy Markdown
Contributor Author

/cc @tengqm

@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 23, 2019 13:17
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Oct 24, 2019

Thanks for getting this fixed.
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 23e8643 into kubernetes:master Oct 24, 2019
@kbhawkey kbhawkey deleted the fix-kubeadm-cmd-link branch October 24, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants