Skip to content

en: Change the full link in the document to an inline link.#17057

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
ysyukr:en-docs-url-fix
Oct 23, 2019
Merged

en: Change the full link in the document to an inline link.#17057
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
ysyukr:en-docs-url-fix

Conversation

@ysyukr
Copy link
Copy Markdown
Contributor

@ysyukr ysyukr commented Oct 21, 2019 •
edited
Loading

Change to inline URL for inconsistent full URLs and inline URLs.

following command

grep -r "https \: \ / \ / kubernetes \ .io" content/en/docs

Changed to inline link except the following list.

  • URLs are mentioned directly in the body
  • release note
  • url to blog
  • url to community
  • Url to be redirected

Changed docs list.

  • /en/docs/concepts/architecture/nodes

Submitted in PR #16909.

  • /en/docs/concepts/configuration/pod-overhead
  • /en/docs/concepts/configuration/pod-priority-preemption
  • /en/docs/concepts/scheduling/kube-scheduler
  • /en/docs/concepts/services-networking/dual-stack
  • /en/docs/concepts/storage/volumes
  • /en/docs/concepts/workloads/pods/pod-overview
  • /en/docs/contribute/localization
  • /en/docs/contribute/style/style-guide
  • /en/docs/reference/access-authn-authz/extensible-admission-controllers
  • /en/docs/reference/glossary/cri
  • /en/docs/reference/kubectl/overview
  • /en/docs/setup/production-environment/tools/kubeadm/troubleshooting-kubeadm
  • /en/docs/setup/production-environment/windows/user-guide-windows-nodes
  • /en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods
  • /en/docs/tasks/administer-cluster/topology-manager
  • /en/docs/tasks/configure-pod-container/configure-runasusername
  • /en/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk

refirence

/from #17056
/language en

@ysyukr
Change the full link in the document to an inline link.
fa22df8 
grep -r "https \: \ / \ / kubernetes \ .io" content/en/docs
Changed to inline link except the following list.
- URLs are mentioned directly in the body
- release note
- url to blog
- url to community
- Url to be redirected
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 21, 2019
@ysyukr ysyukr mentioned this pull request Oct 21, 2019
Merged
26 tasks
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 21, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 64972e2

https://deploy-preview-17057--kubernetes-io-master-staging.netlify.com

@ysyukr ysyukr mentioned this pull request Oct 21, 2019
Closed
5 tasks
@ysyukr ysyukr changed the title Change the full link in the document to an inline link. en: Change the full link in the document to an inline link. Oct 21, 2019
gochist
gochist reviewed Oct 21, 2019
View reviewed changes
@ysyukr @gochist
Apply suggestions from code review
64972e2 
Co-Authored-By: June Yi <june.yi@samsung.com>
@daminisatya
Copy link
Copy Markdown
Contributor

daminisatya commented Oct 21, 2019

/lgtm

@sftim

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019
@daminisatya
Copy link
Copy Markdown
Contributor

daminisatya commented Oct 21, 2019

Thank you @ysyukr for the fix!

@seokho-son seokho-son mentioned this pull request Oct 22, 2019
Merged
5 tasks
@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 22, 2019

/assign

@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 23, 2019

Links appear to be working. Great job!
/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit d437e8c into kubernetes:master Oct 23, 2019
@ysyukr ysyukr deleted the en-docs-url-fix branch October 25, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aramase aramase Awaiting requested review from aramase

@davidopp davidopp Awaiting requested review from davidopp

1 more reviewer

@gochist gochist gochist left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@daminisatya daminisatya

@bradtopol bradtopol

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ysyukr @daminisatya @bradtopol @k8s-ci-robot @gochist