Skip to content

Fix #15161 - Fix card alignments in kubernetes baiscs tutorial page.#17051

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
miteshskj:fix_15161
Oct 30, 2019
Merged

Fix #15161 - Fix card alignments in kubernetes baiscs tutorial page.#17051
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
miteshskj:fix_15161

Conversation

@miteshskj
Copy link
Copy Markdown
Contributor

@miteshskj miteshskj commented Oct 20, 2019 •
edited
Loading

Fixes #15161

The _index.html did not have stylesheet links causing incorrect layout. Included them for all languages which had _index.html files.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2019
@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 20, 2019
@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 20, 2019

fix_1561_en

fix_1561_fr

fix_1561_ja

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 20, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c12fdba

https://deploy-preview-17051--kubernetes-io-master-staging.netlify.com

@bene2k1
Copy link
Copy Markdown
Member

bene2k1 commented Oct 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019
@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 21, 2019

/assign @kbhawkey

@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 21, 2019

Hi @miteshskj .
Thanks for looking into the styling of the tutorial pages and the blog base layout.

  • My version of the page preview shows the layout differently -- the font sizing is not correct
    and the layout appears to be flattened out.
  • Since all language versions of the tutorial use the same CSS files, it would be good
    to include these files in a single CSS file.
  • Is styles.css outdated?

https://deploy-preview-17051--kubernetes-io-master-staging.netlify.com/docs/tutorials/kubernetes-basics/

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2019
@miteshskj miteshskj changed the title Fix #15161 - Adding bootstrap-4.3.1.min.css and other stylesheets to index.html in… Fix #15161 - Fix card alignments in kubernetes baiscs tutorial page. Oct 22, 2019
@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 22, 2019

Thanks for reviewing @kbhawkey
Updated the PR, removed all other css and just included styles.css and it fixed the issues you reported. No need to update styles.css.

Please review again.

@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 22, 2019

Hi @miteshskj. I reviewed the changes and preview again.
Many of the tutorials link to en/docs/tutorials/kubernetes-basics/public/css/styles.css. However, the pages that include this file, appear to alter the font size in the header and footer. I think this change needs further investigation.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@miteshskj miteshskj mentioned this pull request Oct 23, 2019
Closed
6 tasks
@kbhawkey kbhawkey mentioned this pull request Oct 24, 2019
Closed
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 24, 2019

For further information, see #17108.

@kbhawkey kbhawkey mentioned this pull request Oct 24, 2019
Merged
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 24, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2019
@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 24, 2019

@miteshskj , I created a PR (#17177) to fix the styling of the tutorial pages.
With your last commit, did you remove the update of bootstrap.min.css in layouts/blog/baseof.html? I don't see this change anymore.

@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Oct 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@chenrui333
Copy link
Copy Markdown
Member

chenrui333 commented Oct 24, 2019

Thanks!

@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 25, 2019

Thanks @kbhawkey ! Yes I reverted the blog file as the bootstrap css was not needed in index.html so didn't see the need to upgrade the version in blog.

@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 25, 2019

Thanks @kbhawkey ! Yes I reverted the blog file as the bootstrap css was not needed in index.html so didn't see the need to upgrade the version in blog.

OK. If this information is in the commit message, would you remove the comment about updating the blog file?

@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 25, 2019

Commit message was updated, I have updated the PR description to remove the blog file info.

@kbhawkey
Copy link
Copy Markdown
Contributor

kbhawkey commented Oct 25, 2019

@miteshskj , The English version of the page, for the multi-step graphics, looks okay now.

@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 25, 2019

Thank you @kbhawkey

markthink
markthink reviewed Oct 26, 2019
View reviewed changes
Copy link
Copy Markdown

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@daminisatya
Copy link
Copy Markdown
Contributor

daminisatya commented Oct 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bene2k1, daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit b44116f into kubernetes:master Oct 30, 2019
@miteshskj miteshskj deleted the fix_15161 branch October 31, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bene2k1 bene2k1 Awaiting requested review from bene2k1

@chenrui333 chenrui333 Awaiting requested review from chenrui333

1 more reviewer

@markthink markthink markthink left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chenrui333 chenrui333

@kbhawkey kbhawkey

@markthink markthink

@daminisatya daminisatya

@bene2k1 bene2k1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/tutorials/kubernetes-basics/

7 participants

@miteshskj @bene2k1 @kbhawkey @chenrui333 @daminisatya @k8s-ci-robot @markthink