Skip to content

Fix #17014 - Update k8s version info for etcd encryption feature in securing-a-clu…#17027

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
miteshskj:fix_17014
Oct 28, 2019
Merged

Fix #17014 - Update k8s version info for etcd encryption feature in securing-a-clu…#17027
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
miteshskj:fix_17014

Conversation

@miteshskj
Copy link
Copy Markdown
Contributor

@miteshskj miteshskj commented Oct 18, 2019

Fixes #17014
The feature is in beta since 1.13

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 18, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 18, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4cb5658

https://deploy-preview-17027--kubernetes-io-master-staging.netlify.com

@destijl
Copy link
Copy Markdown
Member

destijl commented Oct 18, 2019

AFAIK, there's nothing that makes this Beta apart from documentation. @liggitt @immutableT should we just call it stable?

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 18, 2019

this PR lgtm in the meantime while we figure that out

AFAIK, there's nothing that makes this Beta apart from documentation. @liggitt @immutableT should we just call it stable?

@immutableT, when did the health checks, metrics, and timeouts land?

@immutableT
Copy link
Copy Markdown

immutableT commented Oct 18, 2019 •
edited
Loading

Healthz merged on July 3rd.
Time-out merged on Jan 9th.
The last PR related to metrics merged on Aug 19th

@miteshskj
Copy link
Copy Markdown
Contributor Author

miteshskj commented Oct 22, 2019

@liggitt - Please let me know if we are good to drop the "beta" wording.

@miteshskj miteshskj mentioned this pull request Oct 23, 2019
Closed
6 tasks
@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 24, 2019

Hi @liggitt please add a /lgtm when you feel this is technically correct. I'll then take care of merging it. Thank you for reviewing this!
/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt October 24, 2019 03:20
@bradtopol
Copy link
Copy Markdown
Contributor

bradtopol commented Oct 24, 2019

/assign

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Oct 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2019
@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Oct 28, 2019

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7fa51c9 into kubernetes:master Oct 28, 2019
@miteshskj miteshskj deleted the fix_17014 branch October 30, 2019 15:24
@immutableT
Copy link
Copy Markdown

immutableT commented Nov 4, 2019

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@destijl destijl Awaiting requested review from destijl

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@bradtopol bradtopol

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review “Securing a cluster”

7 participants

@miteshskj @destijl @liggitt @immutableT @bradtopol @tengqm @k8s-ci-robot