Skip to content

Update guaranteed-scheduling-critical-addon-pods.md#16967

Closed
rdxmb wants to merge 1 commit intokubernetes:masterfrom
rdxmb:patch-1
Closed

Update guaranteed-scheduling-critical-addon-pods.md#16967
rdxmb wants to merge 1 commit intokubernetes:masterfrom
rdxmb:patch-1

Conversation

@rdxmb
Copy link
Copy Markdown
Contributor

@rdxmb rdxmb commented Oct 16, 2019

remove old stuff

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 16, 2019

Welcome @rdxmb!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 16, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cody-clark
You can assign the PR to them by writing /assign @cody-clark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 16, 2019
@rdxmb
Copy link
Copy Markdown
Contributor Author

rdxmb commented Oct 16, 2019

/assign @cody-clark

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 16, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 74f4294

https://deploy-preview-16967--kubernetes-io-master-staging.netlify.com

@zparnold
Copy link
Copy Markdown
Contributor

zparnold commented Oct 23, 2019

@rdxmb There's a merge conflict here, can you please fix and re-open?
/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 23, 2019

@zparnold: Closed this PR.

Details

In response to this:

@rdxmb There's a merge conflict here, can you please fix and re-open?
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rdxmb
Copy link
Copy Markdown
Contributor Author

rdxmb commented Oct 23, 2019

@zparnold if you can give me details, I can have a look at it. I created the fork directly from master and haven't wait a long time to create the PR. I also cannot see any merge conflict here in this conversation. Can you send me a link to see what's the problem here?

@rdxmb rdxmb mentioned this pull request Oct 23, 2019
Merged
@rdxmb
Copy link
Copy Markdown
Contributor Author

rdxmb commented Oct 23, 2019

(think I got it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidopp davidopp Awaiting requested review from davidopp

@piosz piosz Awaiting requested review from piosz

Assignees

@cody-clark cody-clark

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rdxmb @k8s-ci-robot @zparnold @cody-clark