Update master to Hugo version 0.57.2#16814
Conversation
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 40ecf09 https://deploy-preview-16814--kubernetes-io-master-staging.netlify.com |
sftim
left a comment
There was a problem hiding this comment.
LGTM, no objection. Not sure I know enough about Hugo to give a solid thumbs up.
|
|
||
| [build.environment] | ||
| HUGO_VERSION = "0.53" | ||
| HUGO_VERSION = "0.57.2" |
There was a problem hiding this comment.
@zacharysarah , Do you know how netlify is configured to use the extended version of Hugo? Just wondered.
Also, the other week I saw PR #16708 upgrade netlify for the code shortcode issue on the release-1.16 branch. I think this PR upgraded Hugo to the latest version.
Has the Makefile been updated to this version of Hugo (for local testing)?
There was a problem hiding this comment.
@kbhawkey - Thanks for pointing that out! The makefile has not been updated. And thanks for pointing out PR 16708, which set the HUGO_VERSION to 0.58.3! That's a release head of 0.57.2, which is specified in this PR.
Your Netflify question is great too! Poking around, it looks like Netlify supplies build images with pre-installed software; [build settings(https://www.netlify.com/docs/build-settings/) and build images. I have not been able to locate information on which versions of Hugo are installed on each build image. However I did come across this: "If you would like to use the new Sass compilation features in recent Hugo releases (using the “extended” version of the binaries), you can use the new build image selection setting (currently in beta) to select the Ubuntu Xenial 16.04 image, which supports all Hugo versions." Kubernetes uses the Ubuntu 16 build image. I didn't find anything on the Netlify site about configuring the Hugo version as '0.57.2/extended' in the netlify.toml file - the docs only mention version numbers.
There was a problem hiding this comment.
Do you know how netlify is configured to use the extended version of Hugo?
I don't. I'm not sure I know what "extended version" means in the context of Hugo--I'll do some research!
I think this PR upgraded Hugo to the latest version.
Thanks for raising visibility on that PR, along with @aimeeu. That's a problematic PR for a host of unrelated reasons, and it's been reverted.
Has the Makefile been updated to this version of Hugo (for local testing)?
Good catch, I'll do that now.
There was a problem hiding this comment.
I noticed that Intermediate - view your changes locally states "Install Hugo version 0.53 or later." That should change to something like "Install the Hugo version specified in website/netlify.toml." Can you make that change in this PR or do you want a separate PR?
There was a problem hiding this comment.
@aimeeu To prevent scope creep, that’s a separate issue and PR. I’m happy to open those and link them to this PR.
|
End user acceptance testing https://deploy-preview-16813--k8s-v1-15.netlify.com/
Locally:
Based on my random testing, I'd say this is good to push once the makefile has been updated. |
Update Makefile for 0.57.2
e4b778c to
40ecf09
Compare
Yup! That's intentional: diluting our SEO across multiple versions of the same page is a bad idea. |
|
/lgtm |
|
/assign @bradtopol |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimangel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR reintroduces #16094, which replicates #16104 and #16151 for
master(and thereby current and future versions).Fixes #16066
Context
#16066 exhibits behavior characteristic of gohugoio/hugo#5615. To resolve the issue, we need to upgrade Hugo to a version that includes the solution.
Because #16094 got lost in the release timing shuffle, this PR didn't make it into
master./sig docs
/priority important-soon
/assign @aimeeu