redirect to vSphere cloud provider docs in cloud providers page by andrewsykim · Pull Request #16778 · kubernetes/website

andrewsykim · 2019-10-09T23:21:55Z

Signed-off-by: Andrew Sy Kim kiman@vmware.com

The vSphere cloud provider has a docs site at https://cloud-provider-vsphere.sigs.k8s.io, we should redirect vSphere users there in the "Cloud Providers" page.

andrewsykim · 2019-10-09T23:23:34Z

/assign @dvonthenen

andrewsykim · 2019-10-09T23:25:18Z

/hold

netlify · 2019-10-09T23:30:07Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 99eac71

https://deploy-preview-16778--kubernetes-io-master-staging.netlify.com

netlify · 2019-10-09T23:39:06Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 104ff5b

https://deploy-preview-16778--kubernetes-io-master-staging.netlify.com

sftim

Here's some feedback.

sftim · 2019-10-10T08:20:56Z

content/en/docs/concepts/cluster-administration/cloud-providers.md

+## vSphere

-### Node Name
+The in-tree vSphere cloud provider is recommended if you are running vSphere < 6.7u3. Quick start for the in-tree cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html).


Suggested change

The in-tree vSphere cloud provider is recommended if you are running vSphere < 6.7u3. Quick start for the in-tree cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html).

If you are running vSphere < 6.7u3, VMware recommend you use the in-tree vSphere cloud provider. See [Running a Kubernetes Cluster on vSphere with kubeadm](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html) for a quick start guide.

sftim · 2019-10-10T08:21:51Z

content/en/docs/concepts/cluster-administration/cloud-providers.md

+The in-tree vSphere cloud provider is recommended if you are running vSphere < 6.7u3. Quick start for the in-tree cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html).

-The VSphere cloud provider uses the detected hostname of the node (as determined by the kubelet) as the name of the Kubernetes Node object.
+For all vSphere deployments on vSphere >= 6.7u3, the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere) - along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver) - is recommended. Quick start for the external cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html)


Suggested change

For all vSphere deployments on vSphere >= 6.7u3, the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere) - along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver) - is recommended. Quick start for the external cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html)

For all vSphere deployments on vSphere >= 6.7u3, VMware recommend the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere), along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver). See [Running a Kubernetes Cluster on vSphere with kubeadm](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html) for a quick start guide.

sftim · 2019-10-10T08:21:59Z

content/en/docs/concepts/cluster-administration/cloud-providers.md

+For all vSphere deployments on vSphere >= 6.7u3, the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere) - along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver) - is recommended. Quick start for the external cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html)

-The `--hostname-override` parameter is ignored by the VSphere cloud provider.
+For in-depth documentation on the vSphere cloud provider, visit the docs site at https://cloud-provider-vsphere.sigs.k8s.io/


Use a hyperlink here.

sftim · 2019-10-10T08:22:30Z

content/en/docs/concepts/cluster-administration/cloud-providers.md

-## VSphere
+## vSphere

-### Node Name


As there are two options, consider using tabs.

davidvonthenen · 2019-10-10T15:25:19Z

Good feedback... plus, I learned about using tabs. 😀

davidvonthenen · 2019-10-10T19:04:29Z

/lgtm

andrewsykim · 2019-10-10T20:22:24Z

@sftim thanks for the feedback, comments addressed

frapposelli · 2019-10-10T22:54:21Z

content/en/docs/concepts/cluster-administration/cloud-providers.md

+
+{{< tabs name="vSphere cloud provider" >}}
+{{% tab name="vSphere >= 6.7U3" %}}
+For all vSphere deployments on vSphere >= 6.7U3, VMware recommends the [external vSphere cloud provider](https://github.com/kubernetes/cloud-provider-vsphere), along with the [vSphere CSI driver](https://github.com/kubernetes-sigs/vsphere-csi-driver). See [Deploying a Kubernetes Cluster on vSphere with CSI and CPI](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/kubernetes-on-vsphere-with-kubeadm.html) for a quick start guide.


would it make sense here to point to CAPV? could be a nice way to get started quickly with vSphere consuming the out-of-tree components mentioned here.

CAPV = https://github.com/kubernetes-sigs/cluster-api-provider-vsphere?

yes -- but I personally don't think we should be prescriptive to deployment solutions in the cloud provider docs.

andrewsykim · 2019-10-16T19:57:39Z

/hold cancel

Comments addressed, PTAL

sftim · 2019-10-17T18:08:41Z

Thinking about this more, I'm not 100% comfortable with “VMWare recommends X”. It'd be more in line with the style guide (and the rest of the page) to write “use X” instead.
However I don't know if that's enough of a concern to block a merge.

andrewsykim · 2019-10-17T18:46:52Z

I agree, I think "VMware recommends" is too prescriptive for kubernetes.io docs. I think just :

For all vSphere deployments on vSphere >= 6.7U3, the external vSphere cloud provider is recommended

👍 ?

zparnold · 2019-10-23T15:35:36Z

/approve
pending @sftim 's lgtm

k8s-ci-robot · 2019-10-23T15:36:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [zparnold]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>

andrewsykim · 2019-10-23T16:52:17Z

@sftim updated wording per your suggestion, PTAL :)

sftim · 2019-10-27T11:29:42Z

/lgtm

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2019

k8s-ci-robot requested review from Rajakavitha1 and sftim October 9, 2019 23:22

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 9, 2019

k8s-ci-robot assigned davidvonthenen Oct 9, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2019

sftim reviewed Oct 10, 2019

View reviewed changes

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2019

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 10, 2019

frapposelli reviewed Oct 10, 2019

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019

redirect to vSphere cloud provider docs in cloud providers page

104ff5b

Signed-off-by: Andrew Sy Kim <kiman@vmware.com>

k8s-ci-robot assigned sftim Oct 27, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2019

k8s-ci-robot merged commit f53c6e1 into kubernetes:master Oct 27, 2019

	The in-tree vSphere cloud provider is recommended if you are running vSphere < 6.7u3. Quick start for the in-tree cloud provider can be found [here](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html).
	If you are running vSphere < 6.7u3, VMware recommend you use the in-tree vSphere cloud provider. See [Running a Kubernetes Cluster on vSphere with kubeadm](https://cloud-provider-vsphere.sigs.k8s.io/tutorials/k8s-vcp-on-vsphere-with-kubeadm.html) for a quick start guide.

Conversation

andrewsykim commented Oct 9, 2019

Uh oh!

andrewsykim commented Oct 9, 2019

Uh oh!

andrewsykim commented Oct 9, 2019

Uh oh!

netlify bot commented Oct 9, 2019

Uh oh!

netlify bot commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sftim left a comment

Choose a reason for hiding this comment

Uh oh!

sftim Oct 10, 2019

Choose a reason for hiding this comment

Uh oh!

sftim Oct 10, 2019

Choose a reason for hiding this comment

Uh oh!

sftim Oct 10, 2019

Choose a reason for hiding this comment

Uh oh!

sftim Oct 10, 2019

Choose a reason for hiding this comment

Uh oh!

davidvonthenen commented Oct 10, 2019

Uh oh!

davidvonthenen commented Oct 10, 2019

Uh oh!

andrewsykim commented Oct 10, 2019

Uh oh!

frapposelli Oct 10, 2019

Choose a reason for hiding this comment

Uh oh!

sftim Oct 11, 2019

Choose a reason for hiding this comment

Uh oh!

andrewsykim Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

andrewsykim commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sftim commented Oct 17, 2019

Uh oh!

andrewsykim commented Oct 17, 2019

Uh oh!

zparnold commented Oct 23, 2019

Uh oh!

k8s-ci-robot commented Oct 23, 2019

Uh oh!

andrewsykim commented Oct 23, 2019

Uh oh!

sftim commented Oct 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

netlify bot commented Oct 9, 2019 •

edited

Loading

andrewsykim commented Oct 16, 2019 •

edited

Loading