Skip to content

Remove trailing spaces (#16742)#16762

Closed
furukawa3 wants to merge 1 commit intokubernetes:masterfrom
furukawa3:remove-trailing-spaces
Closed

Remove trailing spaces (#16742)#16762
furukawa3 wants to merge 1 commit intokubernetes:masterfrom
furukawa3:remove-trailing-spaces

Conversation

@furukawa3
Copy link
Copy Markdown
Contributor

@furukawa3 furukawa3 commented Oct 9, 2019

This PR removes trailing spaces. I found all trailing spaces for following command:

sed -i 's/[ ]*$//' $(find content/ -type f -not -name "*.png" -not -name "*.jpg" -not -name "*.svg" -not -name "*.gif")

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 9, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign xiangpengzhao
You can assign the PR to them by writing /assign @xiangpengzhao in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language labels Oct 9, 2019
@furukawa3
Copy link
Copy Markdown
Contributor Author

furukawa3 commented Oct 9, 2019

/assign @xiangpengzhao

@k8s-ci-robot k8s-ci-robot added language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language labels Oct 9, 2019
@k8s-ci-robot k8s-ci-robot added language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 9, 2019
@furukawa3
Copy link
Copy Markdown
Contributor Author

furukawa3 commented Oct 9, 2019

/assign @sftim

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 9, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 10e1db8

https://deploy-preview-16762--kubernetes-io-master-staging.netlify.com

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Oct 9, 2019

@furukawa3 thank you for the PR.
Would you be willing to withdraw this pull request and replace it with several PRs, one per localization?
See working with localized content. Essentially, PRs that cover lots of locales need lots of approval.

@zacharysarah
Copy link
Copy Markdown
Contributor

zacharysarah commented Oct 10, 2019

@furukawa3 Thanks for this update. I'm closing this PR but I agree with @sftim and would love to see these changes go forward in individual PRs per language.

/close

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 10, 2019

@zacharysarah: Closed this PR.

Details

In response to this:

@furukawa3 Thanks for this update. I'm closing this PR but I agree with @sftim and would love to see these changes go forward in individual PRs per language.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furukawa3
Copy link
Copy Markdown
Contributor Author

furukawa3 commented Oct 10, 2019

I see. Thanks for your suggestion. I'll split this commit into each language!!

@furukawa3 furukawa3 mentioned this pull request Oct 10, 2019
Closed
@raelga raelga mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmetb ahmetb Awaiting requested review from ahmetb

@bboreham bboreham Awaiting requested review from bboreham

Assignees

@xiangpengzhao xiangpengzhao

@sftim sftim

Labels

area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@furukawa3 @k8s-ci-robot @sftim @zacharysarah @xiangpengzhao