Skip to content

2019 Kubernetes Documentation Survey results#16462

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
aimeeu:aimeeu-2019SurveyResultsBlog
Oct 29, 2019
Merged

2019 Kubernetes Documentation Survey results#16462
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
aimeeu:aimeeu-2019SurveyResultsBlog

Conversation

@aimeeu
Copy link
Copy Markdown
Contributor

@aimeeu aimeeu commented Sep 19, 2019 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 19, 2019
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 19, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 3a3fe41

https://deploy-preview-16462--kubernetes-io-master-staging.netlify.com

zacharysarah
zacharysarah suggested changes Oct 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimeeu This is so good! ✨ Some nits, grammar, and formatting suggestions, otherwise LGTM.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2019
@aimeeu aimeeu changed the title [WIP] 2019 Kubernetes Documentation Survey results 2019 Kubernetes Documentation Survey results Oct 8, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2019
@aimeeu
Copy link
Copy Markdown
Contributor Author

aimeeu commented Oct 8, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2019
zacharysarah
zacharysarah suggested changes Oct 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aimeeu Whoops, sorry I was unclear about fencing!

@aimeeu
2019 Kubernetes Documentation Survey results
af59cc3 
Incoporate reviewer feedback
Text and image
Add github location

Signed-off-by: Aimee Ukasick <aimeeu.opensource@gmail.com>
@mrbobbytables
Copy link
Copy Markdown
Member

mrbobbytables commented Oct 16, 2019

/lgtm
I don't think we need all teams to weigh in on this one, will just need to adjust date before going live.

/assign @kbarnard10
for approval + any further comments

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2019
@kbarnard10
Copy link
Copy Markdown
Contributor

kbarnard10 commented Oct 28, 2019

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 28, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbarnard10

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@mrbobbytables
Copy link
Copy Markdown
Member

mrbobbytables commented Oct 28, 2019

Thanks @kbarnard10
@aimeeu release the hold when ready 👍

@aimeeu
Copy link
Copy Markdown
Contributor Author

aimeeu commented Oct 29, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit ae34e1a into kubernetes:master Oct 29, 2019
@aimeeu aimeeu deleted the aimeeu-2019SurveyResultsBlog branch November 18, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cody-clark cody-clark Awaiting requested review from cody-clark

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

1 more reviewer

@zacharysarah zacharysarah zacharysarah requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrbobbytables mrbobbytables

@kbarnard10 kbarnard10

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aimeeu @mrbobbytables @kbarnard10 @k8s-ci-robot @zacharysarah