Skip to content

Issue with k8s.io/docs/tutorials/stateful-application/basic-stateful-set/#15510

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mcbenjemaa:service-nginx
Jul 24, 2019
Merged

Issue with k8s.io/docs/tutorials/stateful-application/basic-stateful-set/#15510
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mcbenjemaa:service-nginx

Conversation

@mcbenjemaa
Copy link
Copy Markdown
Member

replace kubectl error message with the related output

Fixes #15507

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2019
@k8s-ci-robot k8s-ci-robot requested review from enisoc and janetkuo July 23, 2019 15:41
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 23, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 050b4dd

https://deploy-preview-15510--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Copy Markdown
Contributor

tengqm commented Jul 24, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 94d0b0b into kubernetes:master Jul 24, 2019
@IhorHryshkov
Copy link
Copy Markdown

Don't full fix:
Remove this sentence:

Ignore the error. It only indicates that an attempt was made to create the nginx

Because now we don't get error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with k8s.io/docs/tutorials/stateful-application/basic-stateful-set/

4 participants